Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netgen submodule #3793

Merged
merged 47 commits into from
Jul 20, 2024
Merged

Netgen submodule #3793

merged 47 commits into from
Jul 20, 2024

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    02f6737 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e29626 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1382109 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    af48c9e View commit details
    Browse the repository at this point in the history
  5. Initialize+finalize netgen if it's enabled

    Right now this is just a test for include directory and linker issues,
    but it'll also be necessary when we're actually using netgen...
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    adf8829 View commit details
    Browse the repository at this point in the history
  6. Add unit tests for linking with Netgen

    This doesn't really do anything but create and delete an empty mesh,
    but it helped me work out more linker and namespace issues, and it'll be
    a good place to put tests for any issues that we suspect aren't in our
    shim code.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7a74fb0 View commit details
    Browse the repository at this point in the history
  7. Clarify method comment

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    156921e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f234c2a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    26c4f71 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    ce8452c View commit details
    Browse the repository at this point in the history
  11. Add unit test for Netgen interface

    We need a lot more here but this is a start
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d9fac9b View commit details
    Browse the repository at this point in the history
  12. MeshTetInterface needs a virtual destructor

    Fortunately recent clang versions flag this with a warning and our CI
    for them treats warnings as errors.
    
    Let's mark the newly-virtual functions "override" in the subclasses
    while we're at it.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5a6e01c View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f8ad0c9 View commit details
    Browse the repository at this point in the history
  14. Do --enable-netgen w/--enable-optional (default)

    In the medium term I'm hoping this will be robust enough to leave on by
    default; in the short term I want our CI to yell at me about any errors
    this triggers.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5e63553 View commit details
    Browse the repository at this point in the history
  15. Disable OpenCascade in our netgen submodule

    We don't use it yet, we don't have plans to use it in the near future,
    and if cmake thinks we want it but can't find it then it refuses to
    build the parts of netgen we do use.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8878f9e View commit details
    Browse the repository at this point in the history
  16. Disable USE_GUI in netcdf

    We don't need it, and it demands Tcl/Tk which we may not have and may
    not want to download.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7a6b086 View commit details
    Browse the repository at this point in the history
  17. Disable netgen USE_PYTHON

    Our Civet recipe was complaining about the lack of pybind11, but I've
    seen other weird Python errors here too.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    060fbe1 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    a64980b View commit details
    Browse the repository at this point in the history
  19. MeshTetInterface::volume_to_surface_mesh()

    This lets us (re)tetrahedralize volume meshes by turning their
    (outermost) surface into a surface manifold fitting our existing API.
    
    We'll still need to tweak this to save interior points as Steiner points
    for compatibility with our 2D triangulator behavior.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7591224 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    f00cf7f View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    3bb14fb View commit details
    Browse the repository at this point in the history
  22. Assert in Elem::flip

    Why did I not have this API take a reference???
    
    Ought to fix that and deprecate the existing one...
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5eb936c View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    53a629e View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    b40b8d5 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    6563701 View commit details
    Browse the repository at this point in the history
  26. Add tet support to build_sphere

    Predicated on tet support in all_tri(), of course...
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    78dfea2 View commit details
    Browse the repository at this point in the history
  27. Handle HEX8 in all_tri()

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    11c76a2 View commit details
    Browse the repository at this point in the history
  28. Add MeshTools::volume()

    And get rid of an annoying unimplemented declaration (we have the
    functionality under another name though) while we're at it.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    51ecea3 View commit details
    Browse the repository at this point in the history
  29. Fix atavistic comment

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d648fda View commit details
    Browse the repository at this point in the history
  30. Clean up Netgen interface

    This isn't going to be as useful as I'd feared, if we can't support
    no-refinement cases, but it's done and it's working for auto-refinement
    cases.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    336f79d View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    7adcca9 View commit details
    Browse the repository at this point in the history
  32. Move default destructor to .C file

    This fixes our header check; we can't get away with a forward
    declaration if we're asked to generate an UnstructuredMesh destructor.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    217061f View commit details
    Browse the repository at this point in the history
  33. Fix header dependency

    I don't think the move here should require unstructured_mesh.h but my
    compiler disagrees.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    2daef68 View commit details
    Browse the repository at this point in the history
  34. Install netgen headers

    We need a bit of a trick here to make sure the autogenerated headers
    only get generated once.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ce8982c View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    467d7a3 View commit details
    Browse the repository at this point in the history
  36. Netgen install linker fixes

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    6f771fe View commit details
    Browse the repository at this point in the history
  37. Whitespace fix

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    707ebc0 View commit details
    Browse the repository at this point in the history
  38. Fix parallel make install

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    47a8fdd View commit details
    Browse the repository at this point in the history
  39. Add missing header for clang

    gcc probably shouldn't accept this either, but is getting it indirectly.
    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    67a5f58 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    66b0349 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    2635ec2 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    d70ced3 View commit details
    Browse the repository at this point in the history
  43. Re-bootstrap

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5f8b1b0 View commit details
    Browse the repository at this point in the history
  44. Fix missing unique_id guards

    roystgnr committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    beecb68 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    6531372 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Fix --enable-netgen-required

    roystgnr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    97f40a1 View commit details
    Browse the repository at this point in the history
  2. Re-bootstrap

    roystgnr committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1e0da03 View commit details
    Browse the repository at this point in the history