Allow adding additional variables to existing FParser objects #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results of testing c619dec using libmesh_PR_test recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/12333 |
|
Results of testing c619dec using libmesh_PR_test_dbg recipe: Passed on: linux-gnu View the results here: https://www.moosebuild.com/view_job/12334 |
|
If this works with the MOOSE apps, 👍 |
jwpeterson
added a commit
that referenced
this pull request
Mar 2, 2015
Allow adding additional variables to existing FParser objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to add variables to existing and parsed FParser objects (for example copies of fully build parsers). The main use is to add variables to use
RegisterDerivativefrom #463 to make them targets of custom derivatives on demand (i.e. at different levels in an automatic differentiation chain to get a high order derivative).I'm also using
friendto allow theFunctionParserADBaseclass access to private members ofFunctionParserBase. These classes are closely tied together and the only alternative would be straight up modifyingFunctionParserBaseto put in the AD functionality.