-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks for digests #39
Conversation
There were the following issues with your Pull Request
Guidelines are available at https://github.com/libOctavo/octavo/blob/master/CONTRIBUTING.md This message was auto-generated by https://gitcop.com |
@homu r+ |
📌 Commit 0771653 has been approved by |
☀️ Test successful - status |
@briansmith updated in #40 |
Cleanup benches - use block size as base for benchmarks (that will always fire update on state) - use macro to build all benchmarks instead of repeating code Ref #39
Sure, but in theory an implementation could have, say, a 1MB internal buffer, in which case the benchmarks would reduce to measuring |
Actually yes, it is possible, but this is unavoidable. In any case if I want to cheat I could just create bigger buffer. Using block size as benchmark default allow me to check how fast in general my implementation is and how have I improved between versions. It isn't done for sake of comparison between crypto libraries (I think that yours briansmith/crypto-bench is great place for that comparision). |
No description provided.