Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for digests #39

Merged
merged 1 commit into from
Oct 25, 2015
Merged

Add benchmarks for digests #39

merged 1 commit into from
Oct 25, 2015

Conversation

hauleth
Copy link
Member

@hauleth hauleth commented Oct 25, 2015

No description provided.

@GitCop
Copy link

GitCop commented Oct 25, 2015

There were the following issues with your Pull Request

  • Commit: 0771653
    • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/libOctavo/octavo/blob/master/CONTRIBUTING.md


This message was auto-generated by https://gitcop.com

@hauleth
Copy link
Member Author

hauleth commented Oct 25, 2015

@homu r+

@homu
Copy link
Contributor

homu commented Oct 25, 2015

📌 Commit 0771653 has been approved by hauleth

@homu
Copy link
Contributor

homu commented Oct 25, 2015

⌛ Testing commit 0771653 with merge 55a166d...

homu added a commit that referenced this pull request Oct 25, 2015
Add benchmarks for digests

None
@homu
Copy link
Contributor

homu commented Oct 25, 2015

☀️ Test successful - status

@homu homu merged commit 0771653 into master Oct 25, 2015
@hauleth hauleth deleted the benches branch October 25, 2015 21:24
hauleth added a commit that referenced this pull request Oct 26, 2015
@hauleth hauleth mentioned this pull request Oct 26, 2015
@hauleth
Copy link
Member Author

hauleth commented Oct 26, 2015

@briansmith updated in #40

homu added a commit that referenced this pull request Oct 26, 2015
Cleanup benches

- use block size as base for benchmarks (that will always fire update on state)
- use macro to build all benchmarks instead of repeating code

Ref #39
@briansmith
Copy link

Moving all computation to initialization is impossible (as there is no data) and very hard for finalization (not enough memory for big files).

Sure, but in theory an implementation could have, say, a 1MB internal buffer, in which case the benchmarks would reduce to measuring memcpy for the smaller input sizes. In particular, and more realistically, in my implementation, I've been considering using a 1024 bit (128 byte) buffer, regardless of the algorithm. This would make a comparison of the $bytes == 16 and $bytes == 128 cases meaningless for my implementation.

@hauleth
Copy link
Member Author

hauleth commented Oct 26, 2015

Actually yes, it is possible, but this is unavoidable. In any case if I want to cheat I could just create bigger buffer. Using block size as benchmark default allow me to check how fast in general my implementation is and how have I improved between versions. It isn't done for sake of comparison between crypto libraries (I think that yours briansmith/crypto-bench is great place for that comparision).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants