Add contributting.json

circle.yml

@@ -0,0 +1,9 @@
+machine:
+  pre:
+    - curl https://sh.rustup.rs -sSf | sh -s -- -y
+  environment:
+    PATH: $HOME/.cargo/bin:$PATH
+
+test:
+  override:
+    - make all TASK=test

contributting.json

@@ -0,0 +1,38 @@
+{
+  "commit": {
+    "cannot_be_fixup": true,
+
+    "subject_cannot_be_empty": true,
+    "subject_must_be_longer_than": 4,
+    "subject_must_be_shorter_than": 72,
+    "subject_must_be_single_line": true,
+    "subject_must_be_in_tense": "imperative",
+    "subject_must_start_with_case": "lower",
+    "subject_must_end_with_dot": false,
+    "subject_must_include_prefix": {
+      "prefixes": [
+        "feat", "fix", "docs", "style", "refactor", "perf", "test", "chore"
+      ],
+      "require_after_prefix": "(*): "
+    },
+
+    "body_lines_must_be_shorter_than": 72
+  },
+
+  "pull_request": {
+    "subject_cannot_be_empty": true,
+    "subject_must_start_with_case": "upper",
+    "subject_must_not_end_with_dot": false,
+
+    "body_cannot_be_empty": true,
+    "body_must_close_github_issue": true
+  },
+
+  "issue": {
+    "subject_cannot_be_empty": true,
+    "subject_must_start_with_case": "upper",
+    "subject_must_not_end_with_dot": false,
+
+    "body_cannot_be_empty": true
+  }
+}

crypto/src/asymmetric/utils/primes/tests.rs

@@ -25,7 +25,7 @@ pub trait PrimeTest {
 
     fn test_loop(&mut self, num: &BigUint, times: usize) -> Type {
         for _ in 0..times {
-            if self.test(&num).is_composite() {
+            if self.test(num).is_composite() {
                 return Type::Composite;
             }
         }
@@ -88,7 +88,7 @@ impl<'a, T: Rng + 'a> MillerRabin<'a, T> {
 impl<'a, T: Rng + 'a> PrimeTest for MillerRabin<'a, T> {
     fn test(&mut self, num: &BigUint) -> Type {
         let a = self.0.next_u64().to_biguint().unwrap();
-        let (s, d) = Self::greatest_2_divisor(&num);
+        let (s, d) = Self::greatest_2_divisor(num);
 
         Self::witness(num, a, &d, s)
     }

crypto/src/lib.rs

@@ -69,6 +69,8 @@
 #![doc(html_logo_url = "https://raw.githubusercontent.com/libOctavo/octavo/master/docs/logo.png",
        html_root_url = "http://libOctavo.github.io/")]
 
+#![allow(many_single_char_names)]
+
 extern crate byteorder;
 extern crate generic_array;
 extern crate num_bigint as bigint;

crypto/src/stream/chacha20.rs

@@ -13,10 +13,10 @@ struct State([u32; STATE_WORDS]);
 
 macro_rules! quarter_round {
     ($a:expr, $b:expr, $c:expr, $d:expr) => {{
-        $a = $a.wrapping_add($b); $d = $d ^ $a; $d = $d.rotate_left(16);
-        $c = $c.wrapping_add($d); $b = $b ^ $c; $b = $b.rotate_left(12);
-        $a = $a.wrapping_add($b); $d = $d ^ $a; $d = $d.rotate_left( 8);
-        $c = $c.wrapping_add($d); $b = $b ^ $c; $b = $b.rotate_left( 7);
+        $a = $a.wrapping_add($b); $d ^= $a; $d = $d.rotate_left(16);
+        $c = $c.wrapping_add($d); $b ^= $c; $b = $b.rotate_left(12);
+        $a = $a.wrapping_add($b); $d ^= $a; $d = $d.rotate_left( 8);
+        $c = $c.wrapping_add($d); $b ^= $c; $b = $b.rotate_left( 7);
     }}
 }
 
@@ -68,7 +68,7 @@ impl State {
             output[i] = self.0[i].wrapping_add(state[i]);
         }
 
-        self.0[12] = self.0[12] + 1;
+        self.0[12] += 1;
     }
 }