zstd: Support negative compression-levels #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmallon
force-pushed
the
pr.negative_zstd
branch
from
38b2c90
to
c549ea7
Compare
What about making the test depend on output of |
hjmallon
force-pushed
the
pr.negative_zstd
branch
from
c549ea7
to
9e974e8
Compare
|
I have added an extra check to the setting of the variable and I have disabled the new test as I didn't think it was worth writing a new string version comparison routine for. |
hjmallon
force-pushed
the
pr.negative_zstd
branch
from
9e974e8
to
c13d55f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zstd supports 'fast' modes with negative compression-levels