Add AC_PROG_CPP to configure.ac #1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the preprocessor is not detected and it leads to failure with empty $CPP variable being used on la_TYPE_UID_T, leading to a cascade of detection errors and redefinition of some types.
vlc-mirrorer
pushed a commit
to videolan/vlc
that referenced
this pull request
Jan 13, 2021
The preprocessor is not detected and it leads to failure with empty $CPP variable being used on la_TYPE_UID_T, leading to a cascade of detection errors and redefinition of some types. PR sent upstream as libarchive/libarchive#1481.
|
Note that the breakage on CPP detection probably comes from autoconf update (hurray!) adding a more conformant behaviour. |
vlc-mirrorer
pushed a commit
to videolan/vlc-3.0
that referenced
this pull request
Jan 30, 2021
The preprocessor is not detected and it leads to failure with empty $CPP variable being used on la_TYPE_UID_T, leading to a cascade of detection errors and redefinition of some types. PR sent upstream as libarchive/libarchive#1481. Cherry-picked from 17652505b49e98721a6351102c8fd7b026bc61dc. Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>
chrisroberts
added a commit
to chrisroberts/vagrant-installers
that referenced
this pull request
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C preprocessor is not correctly detected in some cases, leading to failures in type detection for
la_TYPE_UID_T, which triggers failure in all subsequents tests asuid_tis redefined.Calling
AC_PROG_CPPmacro ensure that the preprocessor is correctly detected or at least called as$(CC) -Ewhenever the environment needs it and fix those failures.This is needed to continue to build libarchive in videolan/vlc.