Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision detection doesn’t take borders into account #304

Closed
astiob opened this issue Mar 11, 2018 · 1 comment · Fixed by #395
Closed

Collision detection doesn’t take borders into account #304

astiob opened this issue Mar 11, 2018 · 1 comment · Fixed by #395
Labels
compatibility

Comments

@astiob
Copy link
Member

astiob commented Mar 11, 2018 •
edited

Originally reported in #154. I’ve also seen this myself.

The amount of space between two implicitly positioned lines should include the appropriate border widths of both lines.
@astiob astiob mentioned this issue Mar 11, 2018
Closed
@astiob astiob mentioned this issue May 3, 2020
Closed
@astiob
Copy link
Member Author

astiob commented May 3, 2020

An example with screenshots is provided in #333.

@TheOneric TheOneric mentioned this issue May 3, 2020
Closed
TheOneric added a commit to TheOneric/libass that referenced this issue May 16, 2020
@TheOneric
[WIP] Collision detection: take border into account
e8110e8 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 16, 2020
@TheOneric
[WIP] Collision detection: take border into account
6e6cfcd 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 16, 2020
@TheOneric
[WIP] Collision detection: take border into account
6ff9c3e 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 16, 2020
@TheOneric
[WIP] Collision detection: take border into account
63604f6 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 16, 2020
@TheOneric
[WIP] Collision detection: take border into account
c6cfe58 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 17, 2020
@TheOneric
[WIP] Collision detection: take border into account
8d776b5 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 17, 2020
@TheOneric
[WIP] Collision detection: take border into account
e6bf879 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 18, 2020
@TheOneric
[WIP] Collision detection: take border into account
30b4e75 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue May 19, 2020
@TheOneric
[WIP] Collision detection: take border into account
5f6e620 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue Jun 2, 2020
@TheOneric
[WIP] Collision detection: take border into account
ce8f89d 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue Jun 2, 2020
@TheOneric
[WIP] Collision detection: take border into account
7e35a89 
closes libass#304
TheOneric added a commit to TheOneric/libass that referenced this issue Jun 2, 2020
@TheOneric
[WIP] Collision detection: take border into account
4809814 
closes libass#304

With this commit the padding of the BorderStyle=4 box, given by \shad, is no
longer measured from the text without borders, but from the border of the text.
(Alternative description: padding changed from \shad to \shad+\bord)
TheOneric added a commit to TheOneric/libass that referenced this issue Jun 2, 2020
@TheOneric
[WIP] Collision detection: take border into account
9d8abac 
closes libass#304

With this commit the padding of the BorderStyle=4 box, given by \shad, is no
longer measured from the text without borders, but from the border of the text.
(Alternative description: padding changed from \shad to \shad+\bord)
TheOneric added a commit to TheOneric/libass that referenced this issue Jun 6, 2020
@TheOneric
Take border into account during collision detection
b194c48 
closes libass#304

With this commit the padding of the BorderStyle=4 box, given by \shad, is no
longer measured from the text without borders, but from the border of the text.
(Alternative description: padding changed from \shad to \shad+\bord)
@TheOneric TheOneric mentioned this issue Jun 12, 2020
Merged
3 tasks
@astiob astiob closed this as completed in d4728d7 Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Border collision and \an456 stacking TheOneric/libass
1 participant
@astiob