fix my issue

[pingplug]

I tried to fix issue #154
It seems work

[ghost]

change default ScaledBorderAndShadow to 1

I support this, even if it's not "compatible".

[rcombs]

Just was looking at vsfilter source to see, and it's not, and whether we think it's a good idea in general or not, I find it weird to be regressing in a compatibility as part of a fix for a compatibility issue.

[ghost]

Looking at the commit, your changes actually disable ScaledBorderAndShadow, which conflicts with what the commit message says.

[ghost]

Also be aware that you must call ass_set_storage_size() to the size of the video. (This can be a different value from ass_set_frame_size() if the subtitles are rendered into a video frame that has already be scaled, like for rendering in display resolution in a video player.)

[grigorig]

Yes, ScaledBorderAndShadow=1 may be a more sensible default. Can you explain the second commit a bit better, ideally in the commit message?

[pingplug]

rewrite commit message
commit 1 disable the ScaledBorderAndShadow by default like VSFilter does

before

after

commit 2 add a border between two collision texts, makes the space between two collision texts larger than space between two lines, Which is what VSFilter does.

ass file:

[V4+ Styles]
Format: Name, Fontname, Fontsize, PrimaryColour, SecondaryColour, OutlineColour, BackColour, Bold, Italic, Underline, StrikeOut, ScaleX, ScaleY, Spacing, Angle, BorderStyle, Outline, Shadow, Alignment, MarginL, MarginR, MarginV, Encoding
Style: Default,微软雅黑,31,&H00FFFFFF,&H00000000,&H00000000,&H00000000,-1,0,0,0,100,100,0,0,1,1,0,2,30,30,15,1

[Events]
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
Dialogue: 0,0:00:00.00,0:00:27.16,*Default,NTP,0,0,0,,Text1, line1 测试\NText1, line2 测试
Dialogue: 0,0:00:00.00,0:00:27.16,*Default,NTP,0,0,0,,Text2, line1 测试\NText2, line2 测试

[ghost]

It's still not clear whether whatever code you use calls ass_set_storage_size().

I don't know whether changing the ScaledBorderAndShadow default is reasonable; it used not to make any sense with libass (because libass could render to screen resolution, i.e. different frame size than the video frame), but maybe the storage size thing handles this correctly now.

[pingplug]

@wm4 there are may subtitles uses the default resolution 484x480, but the resolution of video is much higher(1920x1080). These subtitles are created and previewed with VSFilter, and the border is not scaled. libass will scale the border, make the border thicker than VSFilter.

[ghost]

That's yet another issue, and not what I asked about.

[pingplug]

ass_set_storage_size() will not change the value of ScaledBorderAndShadow, so I don't think this function can help

[TheOneric]

The two issues this pr attempted to resolve have since been addressed by #390 and #395 .