Parse override tag arguments exactly like VSFilter

[astiob]

This is the master issue for all your argument splitting bugs.

Creating this pull request just so we can have this master issue, even though _the code isn’t presentable._ And I mean it: just look at that faux C++ and Ruby. Do note and comment on my tag macro though; I think it’s pretty nice.

Although actually, isn’t it almost done? Maybe I’ll try to finish it quickly. Maybe. So I did.

Known bugs/missing things (check/tick means it’s fixed):

• isspace can crash on negative values (also in ass_strtod and ass.c:process_info_line)
• the array code isn’t finished
• parse_vector_clip hasn’t been updated
• mystrto* modify the pointer
• empty argument detection is wrong
• \t right boundary is wrong
• https://gist.github.com/astiob/046395b5d99e4b0336fd, Fix override tag argument splitting Cyberbeing/xy-VSFilter#11
• https://gist.github.com/astiob/046395b5d99e4b0336fd, MPC-HC

[astiob]

I’m sure trim_left and trim_right can and should be used in more places that are not currently touched by this PR. We can either add them all to the commit that introduces trim_left and trim_right or do that separately later.

[astiob]

Oh, and trim_right should be tested for speed.

[ghost]

All in all, looks pretty ok IMHO.

[astiob]

I decided to just go with whatever we already use for whitespace, which happens to be just and\t. (Note that\rand\ndon’t matter.) So I modified my functions and looked around for other instances where they might be useful. Guess what… I discovered we hadskip_spacesandrskip_spaces in ass.c.

[astiob]

And now with whole-string drawing text append.

[grigorig]

Looks good to me as well. I assume you have done a good amount of testing.

[astiob]

Merged. (Once again, I failed to remember to push the rebased branch to my fork first and then push it to master to automatically mark the pull request as merged.)