\t argument parsing: missing comma

[rcombs]

Style: OP2,Barmeno,50,&H00FFFFFF,&H000019FF,&H00000000,&H00000000,0,0,0,0,100,100,0,0,1,2,0,2,25,25,30,1

Dialogue: 0,0:01:53.21,0:01:56.09,OP2,,0,0,0,,{\fad(0,200)\blur2\c&H271417&\3c&HEDDBEC&\an8\t(1189,1189\3c&HAC607D&\3a&H5A&\c&HFFFFFF&)}It's scary to {\alpha&HFF&}let go{\alpha&H00&} of the life I cherish
Dialogue: 0,0:01:55.76,0:01:56.09,OP2,,0,0,0,,{\fad(0,220)\c&HFFFFFF&\3c&H734255&\an8\alpha&HFF&\blur2}It's scary to {\alpha&H00&\3c&HAC607D&\3a&H5A&\c&HFFFFFF&}let go{\alpha&HFF&} of the life I cherish

Apparently in VSFilter, these 2 lines appear overlapped at the same position. In libass, the second one is shifted downwards (as I'd expect it to be). Hell if I know why VSFilter doesn't follow the usual behavior here.

[astiob]

Why would you expect it to be shifted downwards? That’s \fad, not \pos.

[rcombs]

2 lines on the same layer; the second gets shifted to prevent overlap? I forget the name for it.

[astiob]

O-oh, because there is no \pos. Yeah. (In libass this is called collision… er… well, just collisions.) Hm… I’ll have to actually test this in VSFilter before I believe it. inb4 I missed something obvious

[rcombs]

I went back and forth with skiddiks on this for a while, not believing that it worked in VSFilter, but he's quite insistent that it's fine.

[astiob]

        if(!fPosOverride && !fOrgOverride && !s->m_fAnimated)
            r = m_sla.AllocRect(s, segment, entry, stse.layer, m_collisions);

and m_fAnimated is set if \t or if \org && (\move || \pos || banner || scroll).
Confirmed in both xy-VSFilter and MPC-HC source code.
Still haven’t tested the file in practice.

[astiob]

Confirmed in guliverkli (VSFilter 2.37) code as well.

[astiob]

But we already disable collision detection on \t.

Oh! There we go. This is a parsing bug and a bug in the script.
\t(1189,1189\3c&HAC607D&\3a&H5A&\c&HFFFFFF&)
\t(1189,1189\
pls comma (until I finish my dissertation and go back to finish implementing the fully compatible parser)

[astiob]

See #94.

[astiob]

Fixed by cc9aaeb.