Add assert check for hash in block_database::unindex

Closes #238
libbitcoin · Nov 18, 2018 · 9ec99dc · 9ec99dc
1 parent d6aa833
commit 9ec99dc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/src/databases/block_database.cpp b/src/databases/block_database.cpp
@@ -455,6 +455,8 @@ bool block_database::unindex(const hash_digest& hash, size_t height,
     if (!element)
         return false;
 
+    BITCOIN_ASSERT(hash == element.key());
+
     const auto original = index(element, false, candidate);
     pop_index(height, manager);
     return true;

diff --git a/test/databases/block_database.cpp b/test/databases/block_database.cpp
@@ -58,7 +58,6 @@ BOOST_FIXTURE_TEST_SUITE(block_database_tests, block_database_directory_setup_fi
 
 BOOST_AUTO_TEST_CASE(block_database__test)
 {
-    // TODO: replace.
     static const auto settings = bc::settings(bc::config::settings::mainnet);
     chain::block block0 = settings.genesis_block;
     block0.set_transactions(
@@ -166,11 +165,6 @@ BOOST_AUTO_TEST_CASE(block_database__test)
     // get 4a without indexing it should fail
     BOOST_REQUIRE(!instance.get(h4a));
 
-    // TODO: The test fails because the hash of element at height 3 is
-    // not compared to h4a in the unindex method    
-    // // unindex block 4a without indexing it should fail
-    // BOOST_REQUIRE(!instance.unindex(h4a, 3, true));
-
     // unindex block 0 - 4 from candidate index
     instance.unindex(h3, 3, true);
     instance.unindex(h2, 2, true);