Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several commands are not implemented. #13

Closed
evoskuil opened this issue Sep 3, 2014 · 10 comments · Fixed by #314
Closed

Several commands are not implemented. #13

evoskuil opened this issue Sep 3, 2014 · 10 comments · Fixed by #314

Comments

@evoskuil
Copy link
Member

evoskuil commented Sep 3, 2014

Several commands that were implemented in Python have been obsoleted and others have been re-implemented.

These are previously-existing commands that have been stubbed in pending implementation in C++.

  • address-embed [implemented]
  • qrcode [version3]

Previously-existing network commands that were dropped from original python implementation.

  • fetch-public-key
  • fetch-utxo [version3]
  • watch-tx

Previously-existing Electrum commands that need to be rewritten to BIP-39.

  • mnemonic-new [implemented]
  • mnemonic-to-seed [implemented]

New commands, based on BIP-38.

  • ec-to-ek [implemented]
  • ek-new [implemented]
  • ek-public [implemented]
  • ek-public-to-address [implemented]
  • ek-public-to-ec [implemented]
  • ek-to-address [implemented]
  • ek-to-ec [implemented]
  • token-new [implemented]

New command, previously envisioned but not implemented.

  • tx-sign
@evoskuil
Copy link
Member Author

address-embed is now implemented/tested. I changed the input from a file requirement to raw binary, accepted as an arg or STDIN, so a file can be piped in but text may also be presented via command line argument. This allows the encoding /decoding of arbitrary data to base 16, which is very useful as most commands require base 16 as a starting point.

@evoskuil evoskuil modified the milestones: 3.0, 2.1 Oct 13, 2014
@ggutoski
Copy link

ggutoski commented Nov 8, 2014

Hi guys. Is there an easy way to get notified each time a tx gets an additional confirmation? Seems like this would be a useful feature. (Is this question relevant to the unsupported watch-tx command?)

@evoskuil
Copy link
Member Author

evoskuil commented Nov 8, 2014

You could approximate using watch-address, although depending on what you are after you may need to watch more than one address.

@skaht
Copy link
Contributor

skaht commented Jul 4, 2015

Will "qrcode" provide functionality similar to qrencode (http://fukuchi.org/works/qrencode/) that generates a QR png file from text, and zxing (latest zebra crossing fork https://github.com/glassechidna/zxing-cpp ) that converts a png file back into text?

@evoskuil
Copy link
Member Author

evoskuil commented Jul 4, 2015

That's the intent. The dependencies may be a bit problematic. I don't like conditional dependencies, but that may be the outcome.

@evoskuil
Copy link
Member Author

evoskuil commented Jul 4, 2015

The lower level functionality should be incorporated into libbitcoin (along with scan from a video feed).

@skaht
Copy link
Contributor

skaht commented Jul 4, 2015

I will have to experiment with zxing to see if it can handle rotated PNG images.

Assuming the most stressing use case, people won't have the patience for properly aligning QR codes at checkout scanners, unlike Bitcoin wallets.

It might be quicker to look at the results of zxing to see if the scanned text follows BIP 20 BNF formula, versus performing an image rotation on all the pixels comprising an QR image.

I'm not a QR technologist, but from my DSP background from 25+ years ago I'm guessing if zxing is applied it will need an interface for a video feed to convert a given frame into a PNG file. If the BNF does not handle rotated QR codes and the trick above doesn't work, then an orientation discriminator may be needed to identify a 2D rotation angle to rotate a PNG image for zxing to consume.

If the QR image is not withing the proper depth-of-foucus (DOF), 2D image focusing software may also need to be applied.

@evoskuil
Copy link
Member Author

Hey, not so fast... we have 4 more commands listed for @thecodefactory to implement!

@thecodefactory
Copy link
Member

I think it's about time to close this issue in favor of a new one listing fetch-publc-key, watch-tx, and tx-sign (with descriptions) as an enhancement. This issue can be referenced by the new one. Thoughts?

@evoskuil
Copy link
Member Author

Sure, but please add new before closing old.

@evoskuil evoskuil closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants