Fix a type in configure.ac and conform to POSIX strsignal #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AC_CHECK_DECLS requires commas between declaration. The missing comma leads to HAVE_DECL_GETLINE_GETTIMEOFDAY which is non-sensical. Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
POSIX requires strsignal() to return a pointer to a char, not a pointer to a const char. [1] On uClibc, and possibly other libcs, this causes problems with the correct declaration in string.h. [1] man 3 strsignal Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
jenkins: ok to test |
|
Thanks for the patches! If you do not have an entry in the AUTHORS file, can you also add a change to that file and add a line for yourself? |
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
|
okay i've added myself to the AUTHORS file as a contributor |
brarcher
added a commit
that referenced
this pull request
Mar 22, 2016
Fix a type in configure.ac and conform to POSIX strsignal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fix to items here, as per the commit messages:
configure.ac: fix typo. AC_CHECK_DECLS requires commas between declaration. The missing comma leads to HAVE_DECL_GETLINE_GETTIMEOFDAY which is non-sensical.
lib/strsignal.c: strsignal() should be not be declared const. POSIX requires strsignal() to return a pointer to a char, not a pointer to a const char. (see man 3 strsignal) On uClibc, and possibly other libcs, this causes problems with the correct declaration in string.h.