-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/pyerfa v2.0.0.2 #101
Release/pyerfa v2.0.0.2 #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but shouldn't we also update .github/workflows/ci_worflows.yml
, to include an actual test with python 3.11?
yes, you are right. Maybe we could also use a more moderns Python version for the base configuration (instead of 3.8). |
Thanks! I think it is fine to just update the latest version tested for now. Aside: what goes wrong with the previous version of numpy? Is that now unsupported (doesn't matter too much, since 2.0.0.1 would still be OK, but just curious). |
Yes, I had problems building locally with numpy 1.20, but I have not investigated the reason. |
OK, will wait until tomorrow before merging and pushing the tag to give @astrofrog a chance to comment. |
Actually the min version of numpy in setup.cfg for install requires should match the one for oldestdeps in tox.ini. Do you want to just update the min version to 1.21? |
sure, done |
Looks good to me now! |
Closes #93