Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/pyerfa v2.0.0.2 #101

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

avalentino
Copy link
Member

@avalentino avalentino commented Mar 19, 2023

Closes #93

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but shouldn't we also update .github/workflows/ci_worflows.yml, to include an actual test with python 3.11?

@avalentino
Copy link
Member Author

Looks good but shouldn't we also update .github/workflows/ci_worflows.yml, to include an actual test with python 3.11?

yes, you are right.
Just pushed a change to use Python 3.11 with devdeps.

Maybe we could also use a more moderns Python version for the base configuration (instead of 3.8).

@mhvk
Copy link
Contributor

mhvk commented Mar 19, 2023

Thanks! I think it is fine to just update the latest version tested for now.

Aside: what goes wrong with the previous version of numpy? Is that now unsupported (doesn't matter too much, since 2.0.0.1 would still be OK, but just curious).

@avalentino
Copy link
Member Author

Yes, I had problems building locally with numpy 1.20, but I have not investigated the reason.
According to NEP 29, support for numpy 1.20 has been dropped at the end of January.
Moreover I have also checked that the same change has been implemented in astropy, so I decided to not spend too much time in investigating.

@avalentino
Copy link
Member Author

avalentino commented Mar 19, 2023

OK, will wait until tomorrow before merging and pushing the tag to give @astrofrog a chance to comment.

@astrofrog
Copy link
Contributor

Actually the min version of numpy in setup.cfg for install requires should match the one for oldestdeps in tox.ini. Do you want to just update the min version to 1.21?

@avalentino
Copy link
Member Author

Actually the min version of numpy in setup.cfg for install requires should match the one for oldestdeps in tox.ini. Do you want to just update the min version to 1.21?

sure, done

@astrofrog
Copy link
Contributor

Looks good to me now!

@avalentino avalentino merged commit f5bdbfa into liberfa:master Mar 20, 2023
@avalentino avalentino deleted the release/pyerfa-v2.0.0.2 branch March 20, 2023 19:06
mhvk added a commit to mhvk/pyerfa that referenced this pull request Mar 22, 2023
@mhvk mhvk mentioned this pull request Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trigger a new release to build Python 3.11 wheels?
3 participants