Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert mininum numpy change #103

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented Mar 22, 2023

This is to ensure astropy LTS does not have to pin. Added an extra test for numpy 1.20 since that was problematic before.

@mhvk
Copy link
Contributor Author

mhvk commented Mar 22, 2023

@avalentino, @astrofrog - I changed the minimum version back to 1.17, given @pllim's comment that it was a problem for LTS (and that really one should not change it in a bug-fix release!). I also added a test with numpy 1.20, which had problems in #101. Here, it seems to pass (perhaps a different ubuntu version and therefore different python? I noticed that on recent python I can no longer pip install numpy==1.17 as the compilation fails...).

Anyway, would be great if you can have a look.

Once merged, all we need to do for a release is to push a tag of 2.0.0.3, right?

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! FWIW, LTS needs numpy>=1.18.

@mhvk
Copy link
Contributor Author

mhvk commented Mar 22, 2023

Thanks, both! I'll merge now...

p.s. Indeed, LTS needs numpy >=1.18, but we used to have 1.17, so I thought I might as well put it back to what it was. With the next ERFA release, we can make a bigger jump.

@mhvk mhvk merged commit e33ee55 into liberfa:master Mar 22, 2023
@mhvk mhvk deleted the revert-mininum-numpy-change branch March 22, 2023 23:44
@pllim
Copy link
Contributor

pllim commented Mar 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants