Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert mininum numpy change #103

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Revert mininum numpy change #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec1701d
Revert "Update min numpy version in setup.cfg"
mhvk Mar 22, 2023
525ba95
Move back oldestdeps so that we actually test oldest supported numpy
mhvk Mar 22, 2023
cd5f321
Also test numpy 1.20, which was problematic in gh-101
mhvk Mar 22, 2023
a29d68b
Changelog entry for 2.0.0.3
mhvk Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci_workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ jobs:
toxenv: test-oldestdeps
toxargs: -v

- name: Test with medium old supported versions of our dependencies
# Test that we do not have a problem with some specific version (gh-101).
# Comment out if not needed.
os: ubuntu-20.04
python: 3.9
toxenv: test-olddeps
toxargs: -v

- name: Test with development versions of our dependencies
os: ubuntu-latest
python: 3.11
Expand Down
5 changes: 5 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
2.0.0.3 (2023-03-22)
====================

- Ensure minimum numpy version of 1.17 continues to work (for astropy LTS).

2.0.0.2 (2023-03-19)
====================

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ requires = numpy
zip_safe = False
tests_require = pytest-doctestplus
setup_requires = setuptools_scm
install_requires = numpy>=1.21
install_requires = numpy>=1.17
python_requires = >=3.7

[options.packages.find]
Expand Down
6 changes: 4 additions & 2 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
envlist =
test{,-oldestdeps,-devdeps}
test{,-oldestdeps,-olddeps,-devdeps}
build_docs
linkcheck
codestyle
Expand Down Expand Up @@ -32,11 +32,13 @@ changedir = .tmp/{envname}
description =
run tests
devdeps: with the latest developer version of key dependencies
olddeps: with medium old versions of key dependencies
oldestdeps: with the oldest supported version of key dependencies

# The following provides some specific pinnings for key packages
deps =
oldestdeps: numpy==1.21.*
oldestdeps: numpy==1.17.* # astropy LTS
olddeps: numpy==1.20.* # something potentially problematic (see gh-101)
devdeps: numpy>=0.0.dev0

# The following indicates which extras_require from setup.cfg will be installed
Expand Down