-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
src/support.sch
Outdated
title | ||
or @kwd-group-type | ||
" role="warn"> | ||
<<name/>> must have a @kwd-group-type or a <title>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands, we actually require a @kwd-group-type
. Probably makes sense to allow only a <title>
since that's used for the heading if it exists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened libero/browser#48.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thewilkybarkid I would suggest not specifying about title/kwd-group-type in the rule context and using report
instead of assert
since the 'or' operator is a little flaky in assert.
This should work:
<rule context="kwd-group">
<report test="not(title) and not(@kwd-group-type)"
role="warn"><<name/>> must have a @kwd-group-type or a <title>.</report>
</rule>
It makes sense to me to only allow title
and kwd
in kwd-group
. There are no instances of any other element in eLife content.
@FAtherden-eLife Thanks, tweaked it a bit.
That's what we'll have for now.
|
No description provided.