Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bold Cyrillics Serif Italics missing #74

Closed
jugi1 opened this issue May 18, 2017 · 19 comments
Closed

Bold Cyrillics Serif Italics missing #74

jugi1 opened this issue May 18, 2017 · 19 comments

Comments

@jugi1
Copy link

jugi1 commented May 18, 2017

Cyrillic Italics for Bold Serif Libertinus are missing.
It is also in Biolinum fonts.

Is there a way to add it?
Thanks for supporting.

@khaledhosny
Copy link
Contributor

They need to be drawn of course, which is something I have no expertise in doing (drawing Cyrillic glyphs).

@khaledhosny khaledhosny added the pr-welcome A PR contributing towards this issue would be welcome. label Oct 28, 2017
@kiwi0fruit
Copy link

kiwi0fruit commented Feb 6, 2018

This is very dissapoining to see that bold italic cyrilic support is in "who knows" future... I know the fast way to add them. But they would be slightly in a miss-style. The best match for Libertinus that I found is PT Astra Serif. See how they fit together (PT means PT Astra Serif was used, Lib means Libertinus Serif was used):
pt_vs_libertinus

For now the workaround is simply to have PT Astra Serif as a fallback font.

PS

As another temporal solution I made Libertin Serif/Libert Serif that are almost the same as Libertinus Serif but different:

  • Libertin Serif doesn't have cyrillic characters at all. In other ways it's the same as Libertinus Serif,
  • Libert Serif doesn't have bold-italic and semibold-italic styles. In other ways it's the same as Libertinus Serif. Chome/Chromium would automatically create bold style from italic on the fly,
  • The best combination in case of css is Libertin Serif, Libert Serif fallback chain. In this case you would have original Linux Libertine bold and semibold italics for Latin and you would have Chrome-generated bold italics for Cyrillic.

Here you can see the quality of Chrome auto bold-italic from italic.

@kiwi0fruit
Copy link

kiwi0fruit commented Feb 9, 2018

Both workarounds are not ideal. The only right solution is to draw them all... Or adapt manually. Waiting for a hero :)

@kiwi0fruit
Copy link

kiwi0fruit commented Feb 21, 2018

More Deltails:

Cyrillic doesn't have bold italic. Cyrillic semibold italic is only slanted instead of real italic. PT Astra Serif (OFL) and Noto Serif (OFL) bold italic can be adapted to Libertinus Serif:

  • Bold italic ж and л should be adapted from Noto Serif:
    • fix л like Libertinus bold r,
    • fix ж like Libertinus bold n, r, c,
  • Bold italic к should be adapted from Libertinus greek bold italic κ, and normal italic к,
  • Bold italic и, у, е, х, a, n, p, o, с, т should be taken from Latin (u, y, e, x, a, n, p, o, c, m),
  • Other bold italic should be adapted from PT Astra Serif:
    • fix й, ц, ш, щ like Libertinus bold u,
    • fix н, ю like Libertinus bold n,
    • fix з, э like Libertinus normal italic з, э,
    • ъ should be adjusted or shortened may be,
    • fix ф like Libertinus bold j,
    • fix ы like Libertinus bold u, i,
    • fix я, ч, ь like Libertinus bold i,
    • fix м like Libertinus bold r, u,
  • Take normal italic д from PT Astra Serif,
  • Fix normal italic ж like c so it's more like bold italic from Noto Serif,
  • From PT Astra Serif adapt normal italic я, м like Libertinus я, м.

A bit more info is here.

@khaledhosny khaledhosny added pr-welcome A PR contributing towards this issue would be welcome. and removed pr-welcome A PR contributing towards this issue would be welcome. labels Mar 30, 2018
@StefanPeev
Copy link
Contributor

StefanPeev commented Apr 11, 2018

@kiwi0fruit @khaledhosny Please, help me with your suggestions and notes and I'll do my best to draw Cyrillic Bold Italic and even the local forms for Bulgarian, Serbian and Macedonian scripts for all fonts in Libertinus family. You could see the first results at the Gallery. When I'm ready I'll ask you to help me to make a PR only for the final SFD file with the new and revised glyphs.
See also #122

@khaledhosny
Copy link
Contributor

I can’t comment on the Cyrillic design, but please see the design guidelines if they are of any help.

@StefanPeev
Copy link
Contributor

StefanPeev commented Apr 13, 2018

@khaledhosny Thank you! Design guidelines are very good! I hope that @kiwi0fruit or @KrasnayaPloshchad could give their comments. Soon I'll be ready for PR. The working variants are already seen at Gallery.

@StefanPeev
Copy link
Contributor

StefanPeev commented Apr 13, 2018

libertinus-cyrillic-peev-01

This is an example how Libertinus Bold Italic looks in its Cyrillic version. There is a lot of work to be done still - for the glyphs design, for the metrics and kerning. If someone is curious to test the working version, I could share it through PR.

@kiwi0fruit
Copy link

kiwi0fruit commented Apr 13, 2018 via email

@StefanPeev
Copy link
Contributor

lsbi-cyr-international-03

Here are Libertinus Bold Italic and PT Astra. The structure of the glyphs is quite different.

@kiwi0fruit
Copy link

kiwi0fruit commented Apr 13, 2018 via email

@kiwi0fruit
Copy link

kiwi0fruit commented Apr 13, 2018 via email

@StefanPeev
Copy link
Contributor

StefanPeev commented Apr 13, 2018

@kiwi0fruit Yes, it's true. But I just show you the moment picture of the work. I do not say the bold italic is done. There is a lot of work to be done still. However, the progress is not small. I will continue to edit glyphs and metrics, and when I think the result is much better, I will share the work file through PR.

@kiwi0fruit
Copy link

kiwi0fruit commented Apr 13, 2018 via email

@StefanPeev
Copy link
Contributor

StefanPeev commented Apr 13, 2018

@kiwi0fruit I hope that it's a good start :) I see some problems in italic version also - but I'll do not touch it. Who made the Cyrillic italic version? It's a good idea if I could contact him - especially if he/she agree we to discuss the italics.

@kiwi0fruit
Copy link

kiwi0fruit commented Apr 13, 2018 via email

@StefanPeev
Copy link
Contributor

@kiwi0fruit Alas there is no way to be made an interpolation between italic and bold italic with FontForge. Obviously the two styles are made absolute separately, which is not a good case - this is the reason the interpolation with FontForge to fail. I will try to prepare at least the Cyrillic version for interpolation with FontForge and thus we will have both good semibold italic version and compatable italic and bold italic version.
But it's a lot of work.

@kiwi0fruit
Copy link

kiwi0fruit commented Apr 13, 2018 via email

@khaledhosny khaledhosny removed pr-welcome A PR contributing towards this issue would be welcome. labels Oct 10, 2018
@khaledhosny
Copy link
Contributor

Fixed in ea760cc already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants