Simplify alpha premultiplication, now supported by sharp #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Maplibre-native outputs premultiplied pixels values. The sharp library did not support it so we added code to cancel the alpha premultiplication. Note that this can only visible onr raster tiles (and probably static maps). The sharp library now supports premultiplied pixels with the right config. Let's use it: it should be faster and easie to maintain. Feature announced here: lovell/sharp#1599 (comment) Feature developped here by @mnutt: lovell/sharp#2685 Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Caerbannog
force-pushed
the
refactor1
branch
from
169e5cb
to
d150bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maplibre-native outputs premultiplied pixels values. The sharp library did not support it so we added code to cancel the alpha premultiplication. Note that this can only visible on raster tiles (and probably static maps).
The sharp library now supports premultiplied pixels with the right config. Let's use it: it should be faster and easier to maintain.
Feature announced here:
lovell/sharp#1599 (comment)
Feature developped here by @mnutt:
lovell/sharp#2685
Raster Before
Raster After (visually identical)
Vector for comparison (with building shadow)
What the problem used to look like
For reference, here is the same zone when premultiplication is not cancelled and
premultiplied: trueis not set.