Accept premultiplied raw inputs #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnutt
force-pushed
the
raw-premultiplied-input
branch
from
3047585
to
2f916f6
Compare
lovell
reviewed
Apr 30, 2021
src/common.cc
Outdated
| @@ -96,6 +96,10 @@ namespace sharp { | |||
| descriptor->rawWidth = AttrAsUint32(input, "rawWidth"); | |||
| descriptor->rawHeight = AttrAsUint32(input, "rawHeight"); | |||
| } | |||
| // Raw pixel input is premultiplied | |||
| if (HasAttr(input, "rawPremultiplied")) { | |||
There was a problem hiding this comment.
If possible, it might be better to ensure inputDescriptor.rawPremultiplied is always set in the JavaScript code to avoid a conditional statement here.
mnutt
force-pushed
the
raw-premultiplied-input
branch
2 times, most recently
from
83cb4f3
to
c0b892a
Compare
mnutt
commented
May 2, 2021
lovell
requested changes
May 3, 2021
mnutt
force-pushed
the
raw-premultiplied-input
branch
from
c0b892a
to
c9d5eb1
Compare
Some inputs may already be premultiplied, and it is more efficient to handle it in libvips than in javascript.
mnutt
force-pushed
the
raw-premultiplied-input
branch
from
c9d5eb1
to
87c38c1
Compare
lovell
approved these changes
May 3, 2021
|
Brilliant, thank you very much, this will be in v0.28.2. |
lovell
added a commit
that referenced
this pull request
May 3, 2021
This comment has been minimized.
This comment has been minimized.
Caerbannog
added a commit
to liberty-rider/tileserver-gl
that referenced
this pull request
Nov 20, 2023
Maplibre-native outputs premultiplied pixels values. The sharp library did not support it so we added code to cancel the alpha premultiplication. Note that this can only visible onr raster tiles (and probably static maps). The sharp library now supports premultiplied pixels with the right config. Let's use it: it should be faster and easie to maintain. Feature announced here: lovell/sharp#1599 (comment) Feature developped here by @mnutt: lovell/sharp#2685 Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Caerbannog
added a commit
to liberty-rider/tileserver-gl
that referenced
this pull request
Nov 23, 2023
Maplibre-native outputs premultiplied pixels values. The sharp library did not support it so we added code to cancel the alpha premultiplication. Note that this can only visible onr raster tiles (and probably static maps). The sharp library now supports premultiplied pixels with the right config. Let's use it: it should be faster and easie to maintain. Feature announced here: lovell/sharp#1599 (comment) Feature developped here by @mnutt: lovell/sharp#2685 Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
acalcutt
pushed a commit
to maptiler/tileserver-gl
that referenced
this pull request
Nov 23, 2023
Maplibre-native outputs premultiplied pixels values. The sharp library did not support it so we added code to cancel the alpha premultiplication. Note that this can only visible onr raster tiles (and probably static maps). The sharp library now supports premultiplied pixels with the right config. Let's use it: it should be faster and easie to maintain. Feature announced here: lovell/sharp#1599 (comment) Feature developped here by @mnutt: lovell/sharp#2685 Signed-off-by: Martin d'Allens <martin.dallens@liberty-rider.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1599.
I'm using
tileserver-glwhich works around using premultiplied inputs like so: https://github.com/maptiler/tileserver-gl/blob/4036d528ec9e/src/serve_rendered.js#L280-L294. This works, but from some simple benchmarks I've run it looks like it's faster to do in libvips than in javascript, especially for large images.I ran into a bit of trouble with the unit test using
assertSimilar, as the tests passed whether or not the image was unpremultiplied first so I ended up comparing the raw output directly.If this approach looks acceptable I can add public API documentation.