Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Feedback (click)
Description
This pull request includes changes to the
ReferenceSequence
class in thesrc/Snps/ReferenceSequence.php
file and the addition of a newResources
class in thesrc/Snps/Resources.php
file.Summary
ReferenceSequence
class constructor to remove thereadonly
keyword from the property declarations.getID()
andgetChrom()
methods in theReferenceSequence
class to return the correct property value.getUrl()
,getPath()
,getAssembly()
,getSpecies()
, andgetTaxonomy()
methods in theReferenceSequence
class to return the correct property value.getBuild()
method in theReferenceSequence
class to use the correct property value.loadSequence()
method in theReferenceSequence
class to use the correct property value.Resources
class in thesrc/Snps/Resources.php
file.Resources
class to initialize thebaseUrl
,localResourceDir
, andhttpClient
properties.downloadResource()
method to theResources
class to download a resource from a given URL to a specified destination path.loadDataFromFile()
method to theResources
class to load data from a file.getReferenceSequence()
method to theResources
class to get aReferenceSequence
object for a given ID.getAssemblyMappingData()
andgetExampleDataset()
to theResources
class.getLocalPathForResource()
method to theResources
class to get the local path for a resource.Fixes #110.
π Latest improvements to Sweep:
π‘ To get Sweep to edit this pull request, you can: