Release 2.1.12 stable pull #1045

Fixes: libevent#863 (cherry picked from commit f05ba67)

When I run make check via automake with a version of 1.12.6 or lower, I got this error: /bin/sh: line 9: ./test_runner_epoll: No such file or directory FAIL: test_runner_epoll /bin/sh: line 9: ./test_runner_select: No such file or directory FAIL: test_runner_select /bin/sh: line 9: ./test_runner_kqueue: No such file or directory FAIL: test_runner_kqueue /bin/sh: line 9: ./test_runner_evport: No such file or directory FAIL: test_runner_evport /bin/sh: line 9: ./test_runner_devpoll: No such file or directory FAIL: test_runner_devpoll /bin/sh: line 9: ./test_runner_poll: No such file or directory FAIL: test_runner_poll /bin/sh: line 9: ./test_runner_win32: No such file or directory FAIL: test_runner_win32 /bin/sh: line 9: ./test_runner_timerfd: No such file or directory FAIL: test_runner_timerfd /bin/sh: line 9: ./test_runner_changelist: No such file or directory FAIL: test_runner_changelist /bin/sh: line 9: ./test_runner_timerfd_changelist: No such file or directory FAIL: test_runner_timerfd_changelist Open the Makefile generated by command ./autogen.sh && ./configure I can see the errors are caused by this line: if $(TESTS_ENVIRONMENT) $${dir}$$tst $(AM_TESTS_FD_REDIRECT); then $${dir}$$tst will expand to ./test_runner_epoll, but test_runner_epoll is only a target in test/include.am, not a file, so it print: /bin/sh: line 9: ./test_runner_epoll: No such file or directory. It seems like a bug in automake 1.12.6. The errors will disappear if I simply upgrade automake to 1.13, and upgrade autoconf to 2.65 (2.65 is the lowest version dependent by automake-1.13). When I build with automake-1.13 and autoconf-2.66, I got another error: configure.ac:667: error: AC_CHECK_SIZEOF: requires literal arguments The code in configure.ac line 667 is : AC_CHECK_SIZEOF(void *) It is a bug in autoconf-2.66 : http://gnu-autoconf.7623.n7.nabble.com/AC-CHECK-SIZEOF-int-is-error-in-autoconf-2-66-td13537.html Finally, everything works fine when using automake-1.13 and autoconf-2.67. Refs: libevent#858 (cherry picked from commit 3f09e92)

Fixes: libevent#865 (cherry picked from commit 101fbe3)

(cherry picked from commit 9c151f3)

signal_int is uninitialized in the !base error path. Signed-off-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit a027629)

argv[1] is currently unconditionally passed as the docroot to send_document_cb(). This is broken if any optional parameters are provided, such as -p <port>. Signed-off-by: David Disseldorp <ddiss@samba.org> (cherry picked from commit 7d71214)

(cherry picked from commit 6186d31)

…_MODE (cherry picked from commit 70daa93)

Call event_debug_note_teardown_ before evcb_evfinalize to avoid possible UAF (if finalizer free's event). (cherry picked from commit 445027a)

v2: Disable non-html generator for doxygen by default v3: convert cmake option to doxygen config (cherry picked from commit 1d1c190)

v2: disable man pages by default (cherry picked from commit f9c6a14)

(cherry picked from commit 6f97026)

Thinking about this more and realizing that this was a mistake, so should be reverted. In a nut shell I guess most of the apps calls event_reinit() from the loop (see [1] for example), and this should be totally fine (the bit with the signals [2] handled in event_reinit() gracefully) [1]: https://archives.seul.org/libevent/users/Aug-2019/msg00009.html [2]: libevent#833 (comment) This reverts commit 497ef90. Reported-by: mikulas@twibright.com Backport-to: 2.1 (cherry picked from commit ddacaef)

- AC_PROG_SED - AC_USE_SYSTEM_EXTENSIONS - AC_TRY_COMPILE -> AC_COMPILE_IFELSE - AC_TRY_RUN -> AC_RUN_IFELSE ... Also use: - AC_CONFIG_AUX_DIR Refs: libevent#870 Fixes: 3f09e92 ("Change the minimum version of automake to 1.13 and autoconf to 2.67") (cherry picked from commit 13b8fc3)

Since sysctl() is deprecated for a long-long time, according to sysctl(2): Since Linux 2.6.24, uses of this system call result in warnings in the kernel log. Fixes: libevent#890 Suggested-by: Pierce Lopez (cherry picked from commit 86f55b0)

Fixes: 86f55b0 ("arc4random: replace sysctl() with getrandom (on linux)") (cherry picked from commit 194a5d8)

Reported-by: Maxim Gorbachyov <maxim.gorbachyov@gmail.com> (cherry picked from commit c3f3534)

(cherry picked from commit 572a565)

(cherry picked from commit 0cd536b)

(cherry picked from commit 148d12a)

if evbuffer_add_file_segment() fails it returns -1, so we should call evbuffer_file_segment_free() only on error, and this -1 not 0. Fixes: 6a81b1f ("Avoid double-free on error in evbuffer_add_file. Found by coverity.") Backport-to: 2.1 (cherry picked from commit 4727150)

* upstream/pr/899: improve the description of parameter to evbuffer_read() regress_buffer: improve testcase for evbuffer_freeze() (cherry picked from commit a977d69)

(cherry picked from commit 8d5c565)

The CMAKE_C_FLAGS_DEBUG, CMAKE_C_FLAGS_RELEASE, CMAKE_C_FLAGS_MINSIZEREL and CMAKE_C_FLAGS_RELWITHDEBINFO options are correctly and deliberately toggled to use the libcmt (/MT) flag options in place of the usual msvcrt (/MD) options, but this isn't necessarily desired by the user. The default choice can be overriden with the EVENT__MSVC_STATIC_RUNTIME cmake option. However, the /MD flag that is the choice of CMake only enters into play for the four types of builds above. If the user introduces another CMAKE_BUILD_TYPE, the base CMAKE_C_FLAGS must not be manipulated, as that value (and the CMAKE_C_FLAGS_{custom} value) have been explicitly chosen by the user/developer deploying this library, and the mismatch between these flags in different dependencies results in link errors. The CMake build schema itself doesn't place an /MD flag in CMAKE_BUILD_TYPE so any /M compile option in that variable needs to be retained. Signed-off-by: William Rowe <wrowe@pivotal.io> Signed-off-by: Yechiel Kalmenson <ykalmenson@pivotal.io> (cherry picked from commit af4b07a)

kevent::udata was switched from intptr_t to void*. Handle both cases with the GCC extension typeof(). (cherry picked from commit 72e6eff)

(cherry picked from commit 78b5bca)

It had been deprecated for a long time (AFAIK), but since glibc-2.29.9000-309-g744e829637 it produces a #warning (cherry picked from commit b9b9f19)

Don't override any -DCMAKE_MODULE_PATH= passed from CLI to eg. test custom Platform/ support. (cherry picked from commit 84affc1)

(cherry picked from commit 5fe83d7)

(cherry picked from commit 53b3be4)

Do not do any assumptions on the error for the EMFILE from getaddrinfo(), expect just any error. Fixes: libevent#924 (cherry picked from commit 4436287)

(cherry picked from commit 9fecb59)

Fixes: 9fecb59 ("Parse IPv6 scope IDs.") Refs: libevent#923 (cherry picked from commit 1495f8b)

(cherry picked from commit dc4be86)

(cherry picked from commit cd15112)

Before: $ git log --format='%aE %aN' --author=yuangongji | sort | uniq -c 30 82787816@qq.com yuangongji 1 82787816@qq.com yuangongji (A) After: $ git log --format='%aE %aN' --author=yuangongji | sort | uniq -c 34 yuangongji@foxmail.com yuangongji (cherry picked from commit 026590f)

…sitive This can be/should be done for regression tests too. Refs: https://ci.appveyor.com/project/libevent/libevent/builds/28916689/job/kg621aa194a0qbym Refs: libevent#917 (comment) v2: EVENT_BASE_FLAG_PRECISE_TIMER (cherry picked from commit 8a34869)

…y symlink Fixes: 669a53f ("cmake: set library names to be the same as with autotools") (cherry picked from commit b9f442e)

…not defined This will allow overriding them in parent cmake rules, i.e. if libevent is used via add_subdirectory(). Closes: libevent#931 (cherry picked from commit 8f13c17)

…world.c (cherry picked from commit 1edb6f6)

(cherry picked from commit 6412f34)

Use the following for openssl 1.1+: - X509_getm_notBefore over X509_get_notBefore - X509_getm_notAfter over X509_get_notAfter - use OPENSSL_VERSION_NUMBER over SSLeay() - add missing headers Refs: openssl/openssl@0b7347effee5 (cherry picked from commit 08981f8)

(cherry picked from commit f0e79ba)

(cherry picked from commit 998e683)

After this patchset http-connect works with pproxy [1]: $ pproxy -l http://:8000/ -vvv & $ http-connect //127.1:8000 http://kernel.org:80/ [1]: https://pypi.org/project/pproxy/ * http-connect: http-connect: do not check connection on GET cb http-connect: set Host header (for CONNECT and GET) (like curl) http-connect: cleanup and helpers http: do not close connection for CONNECT http: do not assume body for CONNECT Fixes: libevent#946 (cherry picked from commit 462f2e9)

(cherry picked from commit fa33819)

autotools don't, plus this will make CI logs cleaner (cherry picked from commit f8a6f12)

@ygj6

Moves the thread into real-time scheduling class, as recommended in [1], it fixes the separate test provided by @ygj6 [2] everywhere (github actions, travis-ci, appveyor) under osx. [1]: https://developer.apple.com/library/archive/technotes/tn2169/_index.html [2]: azat-archive/osx-timers@dde1a6e Although even after this changes the following time-related tests failed on travis-ci: - no_events - del_wait But anyway I guess libevent#940 can be closed, since this fixes the issue in common. * osx-clock: test: Use THREAD_* wrappers in del_notify/del_wait test: move threads created with THREAD_START() to realtime scheduling class too test: put thread into real time scheduling class on osx for better latencies Closes: libevent#940 (cherry picked from commit a6f81aa)

(cherry picked from commit 391003e)

(cherry picked from commit 34d51e1)

Fixes the following tests on osx: - del_wait - no_events Refs: libevent#940 (cherry picked from commit 10504fc)

…ebsd For OSX the socket should be closed, otherwise the "connection refused" will not be triggered. And freebsd can return error from the connect(). (cherry picked from commit 30fe125)

…UPPORT=ON) (cherry picked from commit d0adbc0)

…UPPORT (cherry picked from commit ca2b72c)

Fixes: libevent#950 (cherry picked from commit 2c47305)

(cherry picked from commit 5fbe631)

supposing if base is null, EVBASE_ACQUIRE_LOCK and EVBASE_RELEASE_LOCK would get a coredump, so we add a guard for protection. Signed-off-by: chenguolong <cgl.chenguolong@huawei.com> (cherry picked from commit 968bbd5)

Fix undefined behaviour and application crash that might take place in some rare cases after calling evdns_base_free when there are requests in the waiting queue. Current cleanup procedure in evdns_base_free_and_unlock function includes 2 steps: 1. Finish all inflight requests. 2. Finish all waiting requests. During the first step we iterate over each list in req_heads structure and finish all requests in these lists. With current logic finishing an inflight request (function request_finished) removes it from the inflight requests container and forces a wating connection to be sent (by calling evdns_requests_pump_waiting_queue). When these new requests are sent it is possible that they will be inserted to the list in req_heads that we've already cleaned. So in some cases container of the inflight requests is not empty after this procedure and some requests are not finished and deleted. When timeouts for these requests expire evdns_request_timeout_callback is called but corresponding evdns_base has been already deleted which causes undefined behaviour and possible applicaton crash. It is interesting to note that in old versions of libevent such situation was not possible. This bug was introduced by the commit 14f84bb. Before this commit nameservers were deleted before finishing the requests. Therefore it was not possible that requests from the waiting queue be sent while we finish the inflight requests. (cherry picked from commit 4da9f87)

(cherry picked from commit 114b383)

(cherry picked from commit a11edbf)

- event_init() -> event_base_new() - event_set() -> event_new() - check return value of event_base_dispatch() - use EXIT_SUCCESS/EXIT_FAILURE (cherry picked from commit 4e5a41c)

`AC_CHECK_FUNCS` can not properly check `getaddrinfo` because this function requires some special headers on mingw. Using `AC_CHECK_DECL` can effectively solve this issue. Same for - getnameinfo - getprotobynumber - getservbyname - inet_ntop - inet_pton (cherry picked from commit 6d54be2)

`CheckFunctionExistsEx` is copied from the cmake modules before 3.1.2, which is the minimum required version of libevent. The internal module `CheckFunctionExists`of cmake can completely replace it. (cherry picked from commit 61c5c19)

Using `CheckFunctionExists` on Windows to check `getaddrinfo` will get `not found`, but it actually exists. Using `CheckSymbolExists` with headers will get correct results. Other functions such as `getnameinfo`,`inet_ntop`,etc. have the same issue. (cherry picked from commit 503ba1d)

…T_STATIC_LINK default The current cmake/LibeventConfig.cmake.in has a few problems and I'm not sure how cleanly developed it is. It seems rater complex for the little things I would assume it needs to do. I found two problems that are fixed in this PR: - If the downstream user does not explicitly set LIBEVENT_STATIC_LINK before calling find_package(libevent) then they will not be able to detect the static library, even if its the only one that exists. Since this may be rather strict, I've changed the behavior so that LIBEVENT_STATIC_LINK can be set to ON or OFF, but if unset, it defaults to whatever configuration libevent was built as. - The other problem is a bug. The package configuration needs to unset CMAKE_FIND_LIBRARY_SUFFIXES after use, otherwise all packages that are detected after libevent will be "infected" by this setting. This was a significant problem for us, and is very hard to detect in downstream project, because the order of dependencies will lead to different search results. (cherry picked from commit 1675a55)

Checking functions with `CheckFunctionExists` may get wrong results, we should replace it with `CheckSymbolExists`, which is recommended by the cmake official documentation. Before using `CheckSymbolExists`, we use `CheckIncludeFiles` to check header files and save the available header files in a variable that guarantees `CheckSymbolExists` and `CheckTypeSize` to work correctly. This approach is modeled after the cmake scripts of `curl`. The following functions or files were not found before modification, they can now be found: - msys2 + mingw-8.1.0 on Windows10 or mingw-7.3.0 on Ubuntu-18.04 timerclear timercmp timerisset - windows10 getaddrinfo getnameinfo getprotobynumber getservbyname putenv strtoll timerclear timercmp timerisset - ubuntu-18.04 sys/sysctl.h timeradd timerclear timercmp timerisset - MacOS 10.13 sys/random.h timeradd timerclear timercmp timerisset (cherry picked from commit 41d1d75)

* event_rpcgen.py-cleanup: event_rpcgen.py: fix arguments-differ event_rpcgen.py: fix attribute-defined-outside-init event_rpcgen: suppress some warnings to make pylint clean Don't accumulate arguments in `Entry.GetTranslation` Fix improper string concatenations in lists Fix warnings regarding unused variables Don't override the `type` built-in Call `super` to call methods from the parent class Address `no-self-use` issues reported by pylint Run the code through the black formatter Reformat strings to template Add `argparse` support Precompile regular expressions Use bools instead of ints values where possible Rename all global variables to match the PEP8 spec Handle file pointers with context suite patterns Iterate over `tokens` with a for instead of while Fix indentation for `RpcGenError` Don't override `file` built-in Resolve variable name issues per PEP8 Sort imports per PEP8 (cherry picked from commit dd02ad9)

(cherry picked from commit 5786290)

-l list available methods -m <name> use method (cherry picked from commit 5caffa7)

If present, use GetSystemTimePreciseAsFileTime instead of GetSystemTimeAsFileTime. Available since Windows 8. (cherry picked from commit f0b3160)

(cherry picked from commit 86eafc0)

(cherry picked from commit bdc5200)

* EV_CLOSED-and-EV_ET-fixes: Avoid triggering wrong events with EV_ET set epoll: handle EV_ET for EV_CLOSED too test: cover EV_CLOSED with lots of possible scenarious test: rename simpleclose to simpleclose_rw (since it works via write/read) (cherry picked from commit c10cde4)

- EV_CLOSED is EPOLLRDHUP in epoll - EPOLLRDHUP reported w/o EPOLLHUP if the socket closed with shutdown(SHUT_WR) - EPOLLRDHUP reported w/ EPOLLHUP if the socket closed with close() so in this case epoll backend will detect this event as error (EV_READ|EV_WRITE), since the epoll_ctl() will return EPOLLRDHUP with EPOLLHUP set, but this is not correct, let's fix this. Fixes: libevent#984 (cherry picked from commit 972b456)

Refs: libevent#984 (cherry picked from commit 4c13afa)

…phlpapi.dll (cherry picked from commit 61fc2bf)

(cherry picked from commit 7a46526)

Fixes: libevent#976 (cherry picked from commit f3bc532)

v2 (by azat): - drop package installations - use local .abi-check over $HOME/abi-check for build dir - drop regex check, simply use default values (too complex otherwise) - use sub-shell to avoid cd back - add missing quotes - make the style uniq across the whole file (no tabs for indent, copy-paste?) - drop `set -x`, use `bash -x abi-check.sh` over - drop EVENT_ABI_CHECK - use /usr/bin/env bash as shebang - use `find | xargs` over `cp $(grep -v)` - adjust markdown syntax in abi-check/README.md - adjust link to the publicly available documentation v3 (by azat): - docker image - git check-ignore - make -j8 - allow to change defaults Refs: libevent#887 (cherry picked from commit 735c891)

… though) An error for 1.10 on ci: https://github.com/azat/libevent/runs/647860649?check_suite_focus=true#step:4:219 (cherry picked from commit 448a478)

Replace close with evutil_closesocket Caught with PR libevent#1006 (cherry picked from commit 06a1192)

(cherry picked from commit 8fe35c7)

Refs: libevent#182 (cherry picked from commit 1cc94fe)

(cherry picked from commit 70f6919)

Refs: libevent#182 (cherry picked from commit eee26de)

(cherry picked from commit e8c8951)

(cherry picked from commit f10aaea)

"--style" is invalid: $ ./checkpatch.sh -r HEAD usage: clang-format-diff [-h] [-i] [-p NUM] [-regex PATTERN] [-iregex PATTERN] [-sort-includes] [-v] [-style STYLE] [-binary BINARY] clang-format-diff: error: unrecognized arguments: --style={ Language:... } (cherry picked from commit 866fbb5)

Refs: libevent#1029 (cherry picked from commit 8209a62)

- strip 1 path component - it does not accept file name anymore, only stdin Refs: libevent#1029 (cherry picked from commit 89d313b)

(cherry picked from commit a9aa2b3)

(cherry picked from commit 8b5a4d6)

In some CMake integrations, portions of the toolchain may end up defining CMAKE_USE_PTHREADS_INIT even when EVENT__DISABLE_THREAD_SUPPORT is set for libevent. Modify the build to not rely on this side effect of find_package(Threads, ...) [which could be done elsewhere] but instead to use EVENT__HAVE_PTHREADS which is defined only on the desired codepath. Without this change, affected builds fail as a result of event_pthreads source files being built but with build defines which cause the build to fail. Signed-off-by: Paul Osborne <paul.osborne@smartthings.com> (cherry picked from commit 26d5ff4)

…y_impl() (cherry picked from commit 4528d8e)

evutil.c:2559:1: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' #0 0x4f2be0 in EVUTIL_ISXDIGIT_ libevent/evutil.c:2559:1 #1 0x4bd689 in regname_ok libevent/http.c:4838:7 #2 0x4bc16b in parse_authority libevent/http.c:4958:9 libevent#3 0x4bb8b5 in evhttp_uri_parse_with_flags libevent/http.c:5103:7 libevent#4 0x4bb762 in evhttp_uri_parse libevent/http.c:5050:9 libevent#5 0x4b8f41 in evhttp_parse_query_impl libevent/http.c:3505:9 libevent#6 0x4b8ed7 in evhttp_parse_query libevent/http.c:3569:9 Bug: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23291 Report: https://oss-fuzz.com/testcase-detail/5670743106125824 (cherry picked from commit 37dbb35)

Fixes: runtime error: null pointer passed as argument 2, which is declared to never be null (cherry picked from commit 6f152be)

UBSAN reports: evbuffer/remove_buffer_with_empty3: ../buffer.c:1443:3: runtime error: null pointer passed as argument 2, which is declared to never be null #0 0x7ffff6cd0410 in evbuffer_pullup ../buffer.c:1443 #1 0x5555556d68b9 in test_evbuffer_remove_buffer_with_empty3 ../test/regress_buffer.c:408 #2 0x5555557b95ee in testcase_run_bare_ ../test/tinytest.c:173 libevent#3 0x5555557ba048 in testcase_run_one ../test/tinytest.c:333 libevent#4 0x5555557bc0f8 in tinytest_main ../test/tinytest.c:527 libevent#5 0x555555787702 in main ../test/regress_main.c:528 libevent#6 0x7ffff606c001 in __libc_start_main (/usr/lib/libc.so.6+0x27001) libevent#7 0x55555569436d in _start (/src/le/libevent/.cmake-debug/bin/regress+0x14036d) (cherry picked from commit a0c642a)

This allows the object methods to be properly inherited and called via `super(..)`, addressing breakage with python 2.x, introduced in cfcc093. Fixes libevent#1042. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com> (cherry picked from commit 46c9ead)

…ers) tinytest uses another way of detecting test failures, it uses pipe between child and parent, and if the test function in child returns OK it writes OK flag into pipe, and reads it in parent. However sanitizers uses atexit handlers to detect leaks, and this will not detect failures in case of exit() will be called from the atexit handlers, fix this by checking status after waitpid(). (cherry picked from commit 6754740)

…oo tricky) And cannot be suppressed with suppressions due to setup routines. (cherry picked from commit 3b13a64)

…backs) (cherry picked from commit cdbb237)

- http/https_filter_basic - http/https_filter_chunk_out (cherry picked from commit ec94a6b)

(cherry picked from commit ff4ec5f)

(cherry picked from commit 0ac3cfc)

With some modifications: - drop coverage - drop doxygen - do not deploy ABI check, only artifacts

(cherry picked from commit 9adc9f1)

(cherry picked from commit ce8be23)

(cherry picked from commit e2f938c)

…x gcc) (cherry picked from commit 7b9ba3b)

(cherry picked from commit 9da1743)

UBSAN reports: test/regress_buffer.c:2360:2: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/string.h:140:33: note: nonnull attribute specified here (cherry picked from commit ba19b35)

Some requests may get response (evutil_addrinfo) from gaic_server_cb, in case of cancel_event (10000ms) will not be fast enough. (cherry picked from commit 90bcf2d)

Fixes main/fork under ASAN (LSAN if to be precise) * fix-signal-leak: select: requires reinit (otherwise it leaks signal handlers) poll: requires reinit (otherwise it leaks signal handlers) (cherry picked from commit f6bfa8b)

Fixes: 512c88c ("ci/linux: add dist check") (cherry picked from commit e9a6b12)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.1.12 stable pull #1045

Release 2.1.12 stable pull #1045

Commits on Jun 28, 2020

Commits on Jul 2, 2020

Commits on Jul 5, 2020