Add some missing #if conditionals from Apple's code drop #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
…_CLOSURES Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
jeremyhu
force-pushed
the
closure-ifdef-cleanup
branch
from
c50e054
to
55c6a03
Compare
11 tasks
|
Thanks for getting #620 in. Could you please also merge in this one:
#565 <#565>
That only includes the arm64e changes now. I've split out the separate dylib trampoline changes to #621 as it still needs a bit of integration work, but I don't want it to hold up the arm64e changes.
Thanks,
Jeremy
… On Mar 20, 2021, at 06:06, Anthony Green ***@***.*** ***@***.***>> wrote:
Merged #620 <#620> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#620 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJTJNHWPHX5S5EGAWYGGJTTESMWFANCNFSM4WJJC6DQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests adds some missing
#ifdefsthat we added internally in Apple's sources. Sending this in a separate pull request to reduce noise in some followup pull requests for arm64e and trampoline changes.