Create libGD_logo-1.svg #793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project logo was made libGD_logo-1.svg
vapier
requested changes
Nov 28, 2021
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd"> | ||
| <!-- Copyright Rafał Jopek ( rafaljopek at hotmail com ) --> | ||
| <!-- created: 2021-11-20 --> |
There was a problem hiding this comment.
these date tags aren't useful. just delete them.
| @@ -0,0 +1,49 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
why libGD_logo-1.svg ? seems like logo.svg would suffice.
There was a problem hiding this comment.
The very name "logo.svg" says nothing, suggest libGD_logo.svg
| </style> | ||
| </defs> | ||
| <g id="libGD_logo-1"> | ||
| <metadata id="libGD_logo-1"/> |
There was a problem hiding this comment.
this metadata tag isn't used, so delete it
| <!-- Copyright Rafał Jopek ( rafaljopek at hotmail com ) --> | ||
| <!-- created: 2021-11-20 --> | ||
| <!-- updated: 2021-11-22 --> | ||
| <svg xmlns="http://www.w3.org/2000/svg" xml:space="preserve" width="120mm" height="78mm" version="1.1" style="shape-rendering:geometricPrecision; text-rendering:geometricPrecision; image-rendering:optimizeQuality; fill-rule:evenodd; clip-rule:evenodd" |
There was a problem hiding this comment.
i think a bunch of these style values aren't needed, so trim them
| <defs> | ||
| <style type="text/css"> | ||
| <
|
Can we re open this PR? A SVG logo, even if it can improved, would be nice to have :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project logo was made libGD_logo-1.svg