Fix #790, don't rotate glyph positions with Raqm 0.9.0+ #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raqm will apply the transformation matrix set on the FT_Face itself.
|
Thank you! This generally makes sense to me, but I wonder about that segfault in the Windows MinGW 64 CI; probably unrelated to this PR, but should still be investigated. |
Seems to be transient failure. I tried reverting this commit and all builds passed, and they also passed after restoring the commit. |
|
Thanks for checking, @khaledhosny! @remicollet, @pierrejoye, any objections to merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raqm will apply the transformation matrix set on the FT_Face itself.