Killing Ant. Replacing with java support for executing compilation linking and packaging. Also MSVC toolchain target #69
+3,915
−2,243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tom-Ski
changed the title
SimonIT
reviewed
Jun 30, 2024
gdx-jnigen/src/main/java/com/badlogic/gdx/jnigen/BuildTarget.java
Outdated
Show resolved
Hide resolved
SimonIT
reviewed
Jun 30, 2024
gdx-jnigen/src/main/java/com/badlogic/gdx/jnigen/BuildTarget.java
Outdated
Show resolved
Hide resolved
|
@PokeMMO @SimonIT @Berstanio this is ready for a review now, I've added a list of all the things that have changed in this in the PR description |
|
How bout our lord and savior CMake? :p |
SimonIT
reviewed
Jul 9, 2024
Comment on lines
+72
to
+75
| safeAddMavenPublication("jnigenPackageAndroid_arm64-v8a", project, mavenPublication, "natives-arm64-v8a"); | ||
| safeAddMavenPublication("jnigenPackageAndroid_armeabi-v7a", project, mavenPublication, "natives-armeabi-v7a"); | ||
| safeAddMavenPublication("jnigenPackageAndroid_x86", project, mavenPublication, "natives-x86"); | ||
| safeAddMavenPublication("jnigenPackageAndroid_x86_64", project, mavenPublication, "natives-x86_64"); |
There was a problem hiding this comment.
Can't we iterate over the AndroidABI enum? I don't really like it hard-coded
SimonIT
reviewed
Jul 9, 2024
| return targetsThatMatchOS; | ||
| } | ||
|
|
||
| public static void main (String[] args) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ant kill
Ant is pretty annoying to maintain, and restrictive for things that we want to do, like separating out build targets for ios sim/device targets. No more ant scripts! All of it can be done logically in jnigen api to be executed via code/gradle.
MSVC support
Motivation for this:
Some third party libraries that don't expose source, or are too highly chained to MSVC make it impossible to use with jnigen, due to abi differences and name mangling not being compatible with mingw etc cross compilers on windows. As a fix for this, we can have a separate MSVC build target, so we can still have jni bindings that can target the same code base but just with a different build backend for when libs/source of external libraries are only MSVC compatible.
Features/Changes