Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to current date if SKPaymentTransaction#getTransactionDate() is null #241

Merged

Conversation

prineside
Copy link
Contributor

Resolves #240

Copy link
Member

@MrStahlfelge MrStahlfelge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see if someone else chimes in or if @keesvandieren wants to comment

@prineside
Copy link
Contributor Author

Oh, import is missing - did not notice that. Will fix asap

@keesvandieren
Copy link
Member

Apart from missing import, it looks good. I have iOS apps which have either subscriptions or in-app purchases (non-consumables), and I don't have this issue.

  • What kind of in-app purchases do you have? (subscriptions, consumables, non-consumables)?
  • are you using "App Store Promotion" for in-app-store purchases? I don't have that, but that is a different flow, maybe that is causing it?
  • Is it a specific country, or specific device-type it happens to?

@prineside
Copy link
Contributor Author

Apart from missing import, it looks good. I have iOS apps which have either subscriptions or in-app purchases (non-consumables), and I don't have this issue.

  • What kind of in-app purchases do you have? (subscriptions, consumables, non-consumables)?
  • are you using "App Store Promotion" for in-app-store purchases? I don't have that, but that is a different flow, maybe that is causing it?
  • Is it a specific country, or specific device-type it happens to?

Consumables and non-consumables. No subscriptions / promotions.
We've received reports from 25 different users but, unfortunately, I don't know their device model / iOS version / country.
I'll try to collect this data with the next update

@keesvandieren keesvandieren merged commit bbc86f5 into libgdx:master May 21, 2021
@prineside prineside deleted the issue-240-npe-on-start-null-date branch May 21, 2021 19:50
@prineside
Copy link
Contributor Author

prineside commented May 28, 2021

  • Is it a specific country, or specific device-type it happens to?

User regions: US / AU / GB
CPU: Apple A9 / A10 / A13
Device: iPhone / iPad
OS: 14.0.1 / 14.4 / 14.5
Languange: en
RoboVM version: 2.3.12

I've only received 3 reports till this moment, not sure if it is related to iOS 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE on start of the app (getTransactionDate() or getTransactionDate().toDate() is null)
3 participants