Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-tuning for a few string operations #4

Closed
elfring opened this issue May 5, 2014 · 2 comments
Closed

Fine-tuning for a few string operations #4

elfring opened this issue May 5, 2014 · 2 comments

Comments

@elfring
Copy link

elfring commented May 5, 2014

I find that a few string operations can be optimised in the function "launchVM".

  • How do you think about to assign the result of the expression "execDir + std::string("/config.json")" to a variable?
  • Would it be a bit more efficient to append data to the variable "execDir" instead of using the additional "jarFile"?
@badlogic
Copy link
Member

badlogic commented May 5, 2014

I think we should aim for correctness and ease of use before we do microoptimizations. That being said, having a local var for execDir + std::string("config.json") makes total sense from a DRY perspective.

@badlogic
Copy link
Member

Merged into #11

karlsabo pushed a commit that referenced this issue Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants