Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine-tuning for a few buffer sizes #5

Closed
elfring opened this issue May 5, 2014 · 2 comments
Closed

Fine-tuning for a few buffer sizes #5

elfring opened this issue May 5, 2014 · 2 comments

Comments

@elfring
Copy link

elfring commented May 5, 2014

How do you think about the following update suggestion for the function "getExecutableDir"?

...
+   WCHAR path[MAX_PATH + 1];
    GetModuleFileNameW(hModule, path, MAX_PATH);
+   char dest[(MAX_PATH + 1) * sizeof(WCHAR)];
...
@badlogic
Copy link
Member

badlogic commented May 5, 2014

Really appreciate all the suggestions, but could we maybe summarize them in a single issue?

@badlogic badlogic mentioned this issue May 10, 2014
Closed
@badlogic
Copy link
Member

Merged into #11

karlsabo pushed a commit that referenced this issue Sep 9, 2020
Update readme, add changelog.md
7856fc8 
References #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@badlogic @elfring