-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error in ARM64 Mac system #353
Comments
No, that's really a very nonsensical error... it's trying to link the library before it's built any of the object files? Or did you delete all the rest of the log? Anyways, it looks like the error you reported before? Duplicate symbols, probably (my guess) in the inline file? As before, I don't tend to blame the architecture, as I can build on AWS ARM. |
Looks like the same error @robe2 gets on Windows when enabling inlining. It should build successfully with |
Could it somehow be connected to #288? |
You might find that the current master works. It now builds/regresses on AWS ARM64 with all compilers. |
@pramsey Unfortunately, I am still getting the same error. |
@tzakharko does the workaround I suggested fix it for you? Not suggesting that it's a solution, but if you can confirm the fix, it might help track down the actual solution. |
@dbaston Sorry for the lack of concrete feedback. Here is the full report:
Build log for -DBUILD_SHARED_LIBS=OFF
I couldn't find any other relevant build settings to play with. If you have any ideas, I will gladly be your guinea pig. |
Thanks @tzakharko . This looks looks like the same problem that @robe2 has with the Windows build. I am inclined to suspect the Another option is to remove the file for all platforms. It's not clear to me what problem it's solving. Looks like @strk added it in 2006; maybe he can elaborate? 984bc71 |
Yes, it seems odd to me that the inline functions aren't just in the appropriate headers with INLINE and a #define to switch that to |
Thanks @dbaston, this has been most helpful. Yes, the C++ ABI woes... I have now submitted a simple "fix" as you have suggested. Seems to build fine on my Apple M1 laptop and passes all the tests. The tests also run 50% faster than on my 5.0ghz Intel machine, which is a nice bonus. |
@pramsey I have noticed that the ARM64 fix unfortunately didn't make the cut for the 3.9.0 release... I know it is a bit awkward to ask, but what are the chances of a short-term official version that would build on new Apple hardware? There is some popular open-source software that is currently being blocked on |
We will back patch that to 3.9, makes sense
…On Sun, Dec 20, 2020 at 2:12 AM tzakharko ***@***.***> wrote:
@pramsey <https://github.com/pramsey> I have noticed that the ARM64 fix
unfortunately didn't make the cut for the 3.9.0 release... I know it is a
bit awkward to ask, but what are the chances of a short-term official
version that would build on new Apple hardware? There is some popular
open-source software that is currently being blocked on geos and Homebrew
(an unofficial Mac package manager) maintainers don't feel too comfortable
using a version from trunk...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3ZW26XTUPYFR3JI7OW4DSVXEYVANCNFSM4UFRHVWA>
.
|
I have pulled that commit back into 3.8 and 3.9. Thanks! |
Disable inlining which raise build failures on arm. It should be noted that inlining is already disabled by usptream on arm64: libgeos/geos#353 Fixes: - http://autobuild.buildroot.org/results/52024b2ccc5d17612731809a5dabcc29a4a1170b Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Hello,
I am trying to build
geos
in my ARM64 Mac system, but I am getting an error when themake
process gets to make a dynamic library:Does anyone have an idea for the error?
Thank you.
The text was updated successfully, but these errors were encountered: