MaximumInscribedCircle and LargestEmptyCircleCenter #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e boundary object
nyalldawson
reviewed
Apr 24, 2020
| extern GEOSGeometry GEOS_DLL *GEOSMaximumInscribedCircleRadius(const GEOSGeometry* g, double tolerance); | ||
|
|
||
| /* Constructs the Largest Empty Circle for a set of obstacle geometries, up to a | ||
| * specified tolerance. The obstacles are point and line geometries. |
There was a problem hiding this comment.
Just wondering about the lack of polygon support here... Is there a particular reason why it's skipped?
There was a problem hiding this comment.
Just that it will take a bit more time to implement (it requires additional checks to restrict candidate points lying in the polygons). Hoping to add it soon-ish.
Do you have a use case for that?
There was a problem hiding this comment.
Fair enough!
I was mostly thinking in terms of finding the point furthest from a bunch of buildings
There was a problem hiding this comment.
Yes, that's a good use case. Well, stay tuned... maybe can get this added soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From locationtech/jts#530
WIP