Remove Orientation.isCCW exception #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-jts
force-pushed
the
remove-issccw-exception
branch
from
83acb35
to
34d6bfb
Compare
|
Should probably be noted in |
Yes, definitely. Thanks for the reminder. |
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 23, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 23, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 23, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
BuonOmo
added a commit
to rgeo/rgeo
that referenced
this pull request
Aug 24, 2023
The 3.12 include changes in the API responses. Mainly, WBX Writers now default to three dimensions instead of two. We follow the changes, making no breaking change in the API, but some changes in the responses given by `#ccw?` and `#simplify_preserve_topology`. See changes in libgeos: - libgeos/geos#784 - libgeos/geos#878 - libgeos/geos#908 - libgeos/geos#915 Fixes #360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change behaviour of
Orientation.isCCWandGEOSCoordSeq_isCCWto avoid throwing an exception when the input sequence is short (< 4 vertices). This aligns with JTS semantics, and simplifies logic in internal routines. In particular,normalizenow works on invalid (short) rings without additional checks.