Diff rename detection cycle fixes #1659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @ethomson has pointed out in #1656, diff rename detection has problems when you introduce a cycle of renames (a->b, b->c, c->a) because processing the earlier rename of a->b would alter the diff records so that when it was time process b->c, the b record was no longer the appropriate match.
Instead of making huge changes, this PR fixes this by tweaking a few details:
This PR includes @ethomson's previously failing tests from #1656 and contains my fixes for the issue. Hopefully he will look this over and give it his blessing.