Don't use '__attribute__ visibility' with gcc unless it's at version 4 or better #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 4 or better.
vmg
added a commit
that referenced
this pull request
Sep 19, 2011
Don't use '__attribute__ visibility' with gcc unless it's at version 4 or better
|
Thank you! It's always nice to support older compilers... I'm gonna look into the CMake issue. I don't think there's a standard way to detect compiler version from CMake. |
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
Don't use '__attribute__ visibility' with gcc unless it's at version 4 or better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building libgit2 on an old linux machine using gcc 3.2.3 I found that gcc 3.x does not support attribute((visibility)). This is a patch to allow libgit2 to build with gcc3.
Note: there's a similar problem that -Wextra isn't recognized by gcc3. I hacked around this but don't know enough about CMake to submit a patch for it.