Link mbedTLS
libraries in when SHA1_BACKEND
== "mbedTLS"
#4678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at Julia, we really enjoy the ability to build
libgit2
againstmbedTLS
and completely elide dependency onlibssl
for cryptographic operations. We noticed that with the release ofv0.27.1
there were a few holes in the buildsystem formbedTLS
:The shim routines for
sha1
calculation do not actually get added to the list of files to be compiled.If
SHA1_BACKEND
is set tombedTLS
, butUSE_HTTPS
is not set tombedTLS
,libmbedtls
doesn't get linked properly.I have taken the liberty of editing the travis build configuration to do more complete
mbedTLS
testing.