make proxy_stream_close close target stream even on errors #4905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, I think that we should keep the original error message(s). You can |
When git_filter_apply_fn callback returns a error while smudging proxy_stream_close ends up returning without closing the stream. This is turn makes blob_content_to_file crash as it asserts the stream being closed whether there are errors or not. Closing the target stream on error fixes this problem.
palmin
force-pushed
the
proxy_stream_close
branch
from
15999c6
to
f4835e4
Compare
|
It's ready for another look. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
git_filter_apply_fncallback returns a error while smudgingproxy_stream_closeends up returning without closing the stream. This is turn makes
blob_content_to_filecrash as it asserts the stream being closed whether there are errors or not.
Closing the target stream on error fixes this problem, with the downside being that
error strings set by
proxy_stream->target->close()will override ones set bygit_filter_apply_fncallback.