Set refs/remotes/origin/HEAD to default branch when branch is specified #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 26, 2021 12:13
…specified, attempt 2
ethomson
reviewed
Aug 26, 2021
| @@ -172,7 +172,7 @@ void test_clone_nonetwork__can_checkout_given_branch(void) | |||
|
|
|||
| cl_git_pass(git_reference_lookup(&remote_head, g_repo, "refs/remotes/origin/HEAD")); | |||
There was a problem hiding this comment.
Based on #5791, it looks like git does not create refs/remotes/origin/HEAD at all when --single-branch is specified. Do we have a --single-branch analog where we should we follow suit?
There was a problem hiding this comment.
Thanks for the review! 😊 I don't remember if I checked that (for some reason I think that we've decided to check git --single-branch because that was already the behavior in libgit2), so I'm going to do another test and see if we already follow the suit 👍
|
Sorry for the delay in reviewing this - I appreciate you bumping it up to the top of the list! |
|
This looks good to me - thanks for working on this! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix #5751.
I have first reverted the previous attempt and re-introduced changes that seem to work correctly.
I had to close the original pull request #5791 and open a new one because it was completely forgotten.