-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a long long that crept past #6094
Conversation
There is another one a few lines down. There are a couple more in the EVEN_PARITY macro in deps/ntlmclient/ntml.c if you really want to hunt them all down. |
Whoops. For some reason I didn't catch that one. Will fix later today. I didn't touch ntlmclient because that's imported/vendored and I'm not sure of the process of dealing with that. Also, we should probably set |
It is, but I'm the author. You can feel to make changes either in https://github.com/ethomson/ntlmclient and I'll bring them over here, or vice versa. Whichever you prefer. |
I missed this because I searched for digits before ULL, otherwise it would match terms like "null" or "fully".
This should be propagated to upstream.
Thanks for doing this, I appreciate @boretrk taking the time to review. |
Thanks again! |
No description provided.