Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a long long that crept past #6094

Merged
merged 4 commits into from
Dec 23, 2021

Conversation

NattyNarwhal
Copy link
Contributor

No description provided.

@boretrk
Copy link
Contributor

boretrk commented Oct 18, 2021

There is another one a few lines down.
word = ntohl((uint32_t)(commit_time & 0xffffffffull));

There are a couple more in the EVEN_PARITY macro in deps/ntlmclient/ntml.c if you really want to hunt them all down.

src/commit_graph.c Outdated Show resolved Hide resolved
@NattyNarwhal
Copy link
Contributor Author

Whoops. For some reason I didn't catch that one. Will fix later today.

I didn't touch ntlmclient because that's imported/vendored and I'm not sure of the process of dealing with that.

Also, we should probably set -Wlong-long or something if that can catch long long.

@ethomson
Copy link
Member

I didn't touch ntlmclient because that's imported/vendored and I'm not sure of the process of dealing with that.

It is, but I'm the author. You can feel to make changes either in https://github.com/ethomson/ntlmclient and I'll bring them over here, or vice versa. Whichever you prefer.

I missed this because I searched for digits before ULL, otherwise
it would match terms like "null" or "fully".
This should be propagated to upstream.
src/commit_graph.c Outdated Show resolved Hide resolved
@ethomson
Copy link
Member

ethomson commented Dec 6, 2021

Thanks for doing this, I appreciate @boretrk taking the time to review.

@ethomson ethomson merged commit 4b27009 into libgit2:main Dec 23, 2021
@ethomson
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants