Fix crash when regenerating a patch with unquoted spaces in filename #6244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a null pointer deref in the following scenario:
new file mode ...
ordelete file mode ...
), and has unquoted filenames with spaces in the 1st line of the header.For example, take PATCH_ORIGINAL_NEW_FILE_WITH_SPACE in patch_common.h:
git_diff
from the patch withgit_diff_from_buffer
git_diff_to_buf
I'm not sure the proposed fix is optimal, since it doesn't reproduce the same
diff --git
header line. But, it at least prevents the crash, and vanillagit apply
accepts the resulting patch.