diff: provide more context to the consumer of the callbacks #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arrbee Does this patch reflect what you had in mind? |
Update the callback to provide some information related to the file change being processed and the range of the hunk, when applicable.
|
Looks great! |
arrbee
added a commit
that referenced
this pull request
Apr 30, 2012
diff: provide more context to the consumer of the callbacks
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
diff: provide more context to the consumer of the callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the diff callbacks to provide some information related to the file change being processed and the range of the hunk, when applicable.
The need for this fix has been identified by @yorah while implementing the Diff API in LibGit2Sharp (cf . libgit2/libgit2sharp#136).
Additionally, I've added a tiny accessor
git_buf_len()which I've always missed.If you think it's inappropriate I'll gladly remove it from the PR and will keep on digging into the buffer code to find out if I'm supposed to use the
sizeorasizeproperty :-)