Add signature-handling methods #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/signatures
branch
from
42c0156
to
80e8129
Compare
| } | ||
| } | ||
|
|
||
| return LaxUtf8Marshaler.FromNative(buf.ptr); |
carlosmn
force-pushed
the
cmn/signatures
branch
from
80e8129
to
d6ee519
Compare
We have some methods for creating objects from specific data, but not for creating it out of an existing buffer.
This method returns the signature data along with the rest of the commit without this header field, ready to be fed to whatever authentication method the caller prefers.
First you need to create a buffer which you can apply the signature function to. You can then create the commit object the data and its signature.
carlosmn
force-pushed
the
cmn/signatures
branch
from
d6ee519
to
508807f
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap the library's signed-commit handling methods.
CreateCommitWithSignature()is inObjectDatabasesince that's where the rest are, although we'd want to move them all together intoRepositoryeventually.Fixes #1101