make excluding ignored files the default in status options (perf impr… #1331
Conversation
paulgmiller
force-pushed
the
noignoresdefault
branch
from
a5c60d2
to
1a586e3
Compare
| @@ -652,7 +652,7 @@ public void ForceCheckoutRetainsIgnoredChanges() | |||
| "bin/some_ignored_file.txt", | |||
| "hello from this ignored file."); | |||
|
|
|||
| Assert.Equal(1, repo.RetrieveStatus().Ignored.Count()); | |||
| Assert.Equal(1, repo.RetrieveStatus(new StatusOptions { IncludeIgnored = true }).Ignored.Count()); | |||
There was a problem hiding this comment.
Can we add a similar test: Assert.Equal(0, repo.RetrieveStatus().Ignored.Count()) above this?
|
I'm 👍 on this. @carlosmn ? I think that we should responsibly deprecate this, though. I think that we should hold on to this until after the next release, and immediately merge a note in the I'm not very familiar with all the c# attributes. Is it appropriate to use |
|
I don't know that there is a good way to do this. Yes we should switch the default, but I don't think there's a way to warn about this without it looking like we're going to remove the whole thing. A line in CHANGELOG is probably the best sensible way we have. I'm also not a fan of billing this a performance improvement since you can already do this and the change in behaviour should be made to match git's defaults. |
Switch the default as talked about. Only a few tests had to be changed.