Fixed calling into native libgit2 on osx-arm64 #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frindler Thanks for doing the research on this! Unfortunately, GitHub does not yet offer any arm64 machines for CI, so there was no way to catch this problem with any of our tests. I've read through the links you've provided, and the change you've made here does indeed look to be the best way to handle this since Microsoft hasn't actually fixed it yet. Seem like a major oversight on their part. Can I get you to rebase your branch to the latest |
|
Done. All tests (except for some remote/SSL related issues) pass on my machine using the OSX arm64 .NET 6.0.201 SDK. |
bording
approved these changes
Apr 2, 2022
|
LibGit2Sharp 0.27.0-preview-0182 includes this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1951
The problem are the variadic arguments passed to git_libgit2_opts. On arm64 they need to be padded to start from the 9th argument. The solution is not particularly pretty, but this seems to be the best option at the moment).
See also for more on this issue:
dotnet/runtime#48752
dotnet/runtime#48796