Ensure strings are absent of extra zeroes #703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,7 +202,7 @@ static void DoFetch(RemoteSafeHandle remoteHandle, FetchOptions options, Signatu | |||
| { | |||
| Ensure.ArgumentNotNull(remote, "remote"); | |||
| Ensure.ArgumentNotNull(objectish, "objectish"); | |||
| Ensure.ArgumentNotNullOrEmptyString(destinationSpec, destinationSpec); | |||
| Ensure.ArgumentNotNullOrEmptyString(destinationSpec, "destinationSpec"); | |||
| @@ -100,6 +101,8 @@ public virtual Remote Add(string name, string url) | |||
| { | |||
| Ensure.ArgumentNotNull(name, "name"); | |||
There was a problem hiding this comment.
I think this may also rather be NotNullOrEmpty
|
This one should do, or I will get killed for my incompetence 😱 😄 |
|
@someoneigna The builds appears to fail. Could you please review the logs? |
| @@ -92,6 +92,8 @@ static void DoFetch(RemoteSafeHandle remoteHandle, FetchOptions options, Signatu | |||
| Proxy.git_remote_set_autotag(remoteHandle, options.TagFetchMode.Value); | |||
| } | |||
|
|
|||
| Ensure.ArgumentDoesNotContainZeroByte(logMessage, "logMessage"); | |||
There was a problem hiding this comment.
Maybe move this to the top of the method, as we tend to do for arg validation?
before reaching libgit2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for extra zeroes in strings passed to libgit2 functions.
Fixes #571