Clarify GTDiff options argument documentation #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diff initializers refer to their options arguments taking "any of the above options", but both GTDiffOptions and GTDiffFindOptions are defined above them and the diff initializers really only accept GTDiffOptions.
|
Thanks a lot for the contribution! This makes perfect sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff initializers refer to their options arguments taking "any of the above options", but both
GTDiffOptionsandGTDiffFindOptionsare defined above them and the diff initializers really only acceptGTDiffOptions.I got this mixed up in practice, resulting in this bugfix.