-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve string type error in GTBlob.m #650
resolve string type error in GTBlob.m #650
Conversation
macosx: 10.13.4, XCode Version 9.3 (9E145) reported this error compiling line 43 in GTBlob.m: Format specifies type 'ssize_t' (aka 'long') but the argument has type 'git_off_t' (aka 'long long') and suggested this fix: Replace '%zi' with '%lli' After applying the change xcode built objective-git successfully
ObjectiveGit/GTBlob.m
Outdated
@@ -40,7 +40,7 @@ | |||
@implementation GTBlob | |||
|
|||
- (NSString *)description { | |||
return [NSString stringWithFormat:@"<%@: %p> size: %zi, content: %@, data = %@", NSStringFromClass([self class]), self, [self size], [self content], [self data]]; | |||
return [NSString stringWithFormat:@"<%@: %p> size: %%lli, content: %@, data = %@", NSStringFromClass([self class]), self, [self size], [self content], [self data]]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's an extraneous % in there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
it was too late at night and I took a shortcut by making the change directly on github
pls squash with previous commit
@tiennou Travis is still building on Xcode 8.3. Maybe worth an update too. 😀 |
Contains bugfix libgit2/objective-git#650, which reported this error compiling line 43 in GTBlob.m: Format specifies type 'ssize_t' (aka 'long') but the argument has type 'git_off_t' (aka 'long long')
macosx: 10.13.4, XCode Version 9.3 (9E145)
reported this error compiling line 43 in GTBlob.m:
Format specifies type 'ssize_t' (aka 'long') but the argument has type 'git_off_t' (aka 'long long')
and suggested this fix:
Replace '%zi' with '%lli'
After applying the change xcode built objective-git successfully