fix blame argument handling #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argument handling for the new Repository_blame had several problems: - The call to PyArg_ParseTupleAndKeywords was missing &path, so none of the optional arguments got parsed correctly. - newest_commit and oldest_commit were missing type validation against OidType. - The opts structure was discarded rather than passed to git_blame_file. This commit fixes these issues and adds a test case.
|
Great, so it's not just me. |
cvrebert
added a commit
to hulu/restfulgit
that referenced
this pull request
Dec 21, 2013
Currently disabled/broken due to a bug in the underlying pygit2 API. The bug has been fixed, but they haven't yet made a new release w/ the fix. See libgit2/pygit2#297
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument handling for the new
Repository_blamehad several problems:PyArg_ParseTupleAndKeywordswas missing&path, so noneof the optional arguments got parsed correctly.
newest_commitandoldest_commitwere missing type validationagainst
OidType.optsstruct was discarded rather than passed togit_blame_file.This commit fixes these issues and adds a test case.