-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use pygit2's blame support #1
Comments
I had a go at this but it seems that migrating to pygit2's blame actually slows things down. It's unclear to me what's going on under the hood (I'd need to be able to debug libgit2 itself). |
That's strange, but thanks a lot for trying! Maybe ask the pygit2 or libgit2 community for advice? |
According to my experiments the slowdown is due to libgit2 itself: libgit2/libgit2#3027. So it's probably better to stick to the current solution. |
Well thanks a lot for trying anyway! I guess we just need to watch this space... |
If the new impl works, would it be sensible to leave it behind a gruesomely named opt in, so a test could track when upstream libgit is doing better? |
Makes sense! |
Around the same time I originally developed
git-deps
, the good pygit2 folk added blame support topygit2
. However it didn't quite work. I fixed it but still need to convertgit-deps
to take advantage. This should result in a fairly significant performance boost.The text was updated successfully, but these errors were encountered: