Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for username/password and ssh keypair credentials. Add support for them in the Remote as well as
clone_repository()
. The parameters expect a callback, but the provided types already provide the right__call__
interface.There's a bit of sausage-making in this PR, with a bunch of code being removed in the middle, but I've kept it to show the process by which I arrived at this design.
Credentials implement two attributes, and the pygit2 code extracts the information from a tuple and passes it on to libgit2.