Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support SSL when embed build libgit2 #416

Closed
alexband opened this issue Sep 2, 2014 · 2 comments
Closed

support SSL when embed build libgit2 #416

alexband opened this issue Sep 2, 2014 · 2 comments

Comments

@alexband
Copy link

alexband commented Sep 2, 2014

before we use embed builded libgit2 & a fork of pygit2 in our environment

as #354 introduces credential , it needs libgit2 version which build with SSL support

this the same problem described here: libgit2/rugged#260

I'm trying to fix this in my environment and I would like to get some help how to build an embedded version of libgit2 with SSL support to pair with my pygit2 upgrade

@carlosmn
Copy link
Member

carlosmn commented Sep 2, 2014

How is it the same issue? We don't provide statically-built versions. pygit2 supporting credentials does not mean you need a version of libgit2 built with OpenSSL support (if it does that's a bug in libgit2).

As for building a static version of libgit2, you pass -DBUILD_SHARED_LIBS=OFF -DCMAKE_C_FLAGS=-fPIC to CMake when configuring it. You then need to make _pygit2.so contain that code and link that to libgit2's dependencies. See rugged and git2go for examples of how to get that form pkg-config.

@alexband
Copy link
Author

alexband commented Sep 2, 2014

@carlosmn maybe because we use the embed version make -f Makefile.embed

now I managed to to follow the CMAKE from rugged example and then make _pygit2.so with -Lssl and -Lcrypto seems fix my problem

so I closed the issue

thanks

@alexband alexband closed this as completed Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants